Page MenuHome
Differential D11099

Gpencil: Fix for SVG import arc and float errors
ClosedPublic
Actions

Authored by Erik Abrahamsson (erik85) on Apr 27 2021, 5:10 PM.

Details

Reviewers
Antonio Vazquez (antoniov)
Falk David (filedescriptor)
Commits
rB11dc674c78b4: Gpencil: Fix for SVG import arc and float errors
Summary

Fix for the Arc commands (A/a) to successfully parse the 4th and 5th arguments.
Fix for floats without a specified integer part, like .123

File for testing:

wheelchair-symbolic.svg1 KBDownload

Diff Detail

Repository
rB Blender

Event Timeline

Erik Abrahamsson (erik85) requested review of this revision.Apr 27 2021, 5:10 PM
Erik Abrahamsson (erik85) created this revision.
Antonio Vazquez (antoniov) added a reviewer: Falk David (filedescriptor).Apr 27 2021, 5:11 PM
Antonio Vazquez (antoniov) added inline comments.Apr 27 2021, 5:18 PM
source/blender/io/gpencil/nanosvg/nanosvg.h
2417

IRC, you can use the preferred format:

if (*s && (ELEM(cmd, 'a', 'A')) && (ELEM(nargs, 3, 4))) {

Erik Abrahamsson (erik85) updated this revision to Diff 36569.Apr 27 2021, 5:26 PM
Erik Abrahamsson (erik85) marked an inline comment as done.
Erik Abrahamsson (erik85) edited the summary of this revision. (Show Details)

Updated according to comment.

Falk David (filedescriptor) added inline comments.Apr 27 2021, 6:03 PM
source/blender/io/gpencil/nanosvg/nanosvg.h
1577

Why does this need to be a while loop? I think if was correct here.

Erik Abrahamsson (erik85) added inline comments.Apr 27 2021, 6:19 PM
source/blender/io/gpencil/nanosvg/nanosvg.h
1577

To remove -. if present.

Erik Abrahamsson (erik85) updated this revision to Diff 36573.Apr 27 2021, 6:45 PM
Erik Abrahamsson (erik85) marked an inline comment as done.

Moved special case from main loop to nsvg__getNextPathItem

Falk David (filedescriptor) accepted this revision.Apr 27 2021, 7:53 PM
This revision is now accepted and ready to land.Apr 27 2021, 7:53 PM
Erik Abrahamsson (erik85) updated this revision to Diff 36585.Apr 28 2021, 12:39 AM

I noticed there was a fix commited for the float error at nanosvg on github so I changed the patch to match that.

Falk David (filedescriptor) accepted this revision.Apr 28 2021, 7:37 AM
Closed by commit rB11dc674c78b4: Gpencil: Fix for SVG import arc and float errors (authored by Erik Abrahamsson (erik85), committed by Antonio Vazquez (antoniov)). · Explain WhyApr 28 2021, 3:57 PM
This revision was automatically updated to reflect the committed changes.
Antonio Vazquez (antoniov) added a commit: rB11dc674c78b4: Gpencil: Fix for SVG import arc and float errors.

Revision Contents
Changeset List

PathSize
source/
blender/
io/
gpencil/
nanosvg/
17 lines

Diff 36567

View Options

source/blender/io/gpencil/nanosvg/nanosvg.h

Loading...