Page MenuHome
Differential D11102

Fix Compositor: WorkScheduler task model deletes works
ClosedPublic
Actions

Authored by Manuel Castilla (manzanilla) on Apr 27 2021, 11:03 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Group Reviewers
Compositing
Commits
rB05b1f966fd3c: Fix Compositor: WorkScheduler task model deletes works
rB3d902b4b047b: Fix Compositor: WorkScheduler task model deletes works
Summary

WorkScheduler task model deletes work packages after executing them. The other models don't do so. All models should handle packages the same way.

Diff Detail

Repository
rB Blender
Branch
fix-cmp-scheduler (branched from master)
Build Status
Buildable 14266
Build 14266: arc lint + arc unit

Event Timeline

Manuel Castilla (manzanilla) requested review of this revision.Apr 27 2021, 11:03 PM
Manuel Castilla (manzanilla) created this revision.
Harbormaster completed remote builds in B14266: Diff 36583.Apr 27 2021, 11:03 PM
Manuel Castilla (manzanilla) added a reviewer: Compositing.Apr 27 2021, 11:05 PM
Jeroen Bakker (jbakker) accepted this revision.Apr 28 2021, 8:19 AM
Jeroen Bakker (jbakker) added a subscriber: Jeroen Bakker (jbakker).

Didn't I pushed this change? I recall fixing this some time ago. Anyhow yes task should not be deleted. I expect this to land in 2.93.

This revision is now accepted and ready to land.Apr 28 2021, 8:19 AM
Closed by commit rB3d902b4b047b: Fix Compositor: WorkScheduler task model deletes works (authored by Manuel Castilla (manzanilla), committed by Jeroen Bakker (jbakker)). · Explain WhyApr 28 2021, 8:36 AM
This revision was automatically updated to reflect the committed changes.
Jeroen Bakker (jbakker) added a commit: rB3d902b4b047b: Fix Compositor: WorkScheduler task model deletes works.
Jeroen Bakker (jbakker) added a commit: rB05b1f966fd3c: Fix Compositor: WorkScheduler task model deletes works.
Andres Stephens (Draise) awarded a token.Apr 28 2021, 3:03 PM

Revision Contents
Changeset List

PathSize
source/
blender/
compositor/
intern/
1 line

Diff 36583

View Options

source/blender/compositor/intern/COM_WorkScheduler.cc

Loading...