Details

Reviewers

Commits

rBb42ce0c54cab: Functions: Generic array data structure

Summary

Sometimes it's useful to pass around a set of values with a generic type.
The virtual array data structures allow this, but they don't have logical
ownership. My initial use case for this is as a return type for the functions
that interpolate curve attributes to evaluated points, but a need for this data
structure has come up in a few other places, and it seems generally useful
and non-problematic.

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Apr 28 2021, 12:24 AM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B14267: Diff 36584.Apr 28 2021, 12:24 AM

Various improvements

Add copy and move constructors (and the assign versions)
Add many comments
Add more tests
Remove move constructor from blender::Array (wasn't feasable with the current methods exposed in Array
Lots of fixes

There are two remaining things:

I'd like to be able to this: Array<GArray> arrays, currently it doesn't compile.
I have to case the size argument to int64_t or it tries to interpret it as an allocator..

Harbormaster completed remote builds in B16396: Diff 40659.Aug 13 2021, 7:33 AM

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)Aug 13 2021, 7:34 AM

Hans Goudey (HooglyBoogly) added a reviewer: Jacques Lucke (JacquesLucke).

Merge branch 'master' into generic-array
Add newline

Harbormaster completed remote builds in B16586: Diff 41029.Aug 23 2021, 11:35 PM

Hans Goudey (HooglyBoogly) retitled this revision from Generic array data structure (WIP) to Generic array data structure.Aug 23 2021, 11:35 PM

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)

Jacques Lucke (JacquesLucke) added inline comments.Sep 2 2021, 1:22 PM

source/blender/functions/FN_generic_array.hh
150	This expects that there is a `NoExceptConstructor` constructor.
source/blender/functions/tests/FN_generic_array_test.cc
110	You have to use `GArray<>` here.

Thanks, that seems to do it!

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)Sep 3 2021, 11:32 PM

Merge branch 'master' into generic-array
Fixes suggested by Jacques

Harbormaster completed remote builds in B16813: Diff 41433.Sep 3 2021, 11:33 PM

Hans Goudey (HooglyBoogly) added a child revision: D12785: Geometry Nodes: Fields transfer attribute node.Oct 13 2021, 6:45 PM

Merge branch 'master' into generic-array
Fix comment, default variable values
Add GVArray_For_GArray based on GVArray_For_GSpan

Harbormaster completed remote builds in B17824: Diff 43299.Oct 14 2021, 3:47 PM

Jacques Lucke (JacquesLucke) requested changes to this revision.Oct 14 2021, 3:51 PM

Jacques Lucke (JacquesLucke) added inline comments.

source/blender/functions/FN_generic_virtual_array.hh
409	This constructor still has to set `data_`.

This revision now requires changes to proceed.Oct 14 2021, 3:51 PM

Add NOLINT to use after move
Fix GVArray_For_GArray constructor

Harbormaster completed remote builds in B17825: Diff 43301.Oct 14 2021, 4:17 PM

Hans Goudey (HooglyBoogly) added inline comments.Oct 14 2021, 4:18 PM

source/blender/functions/FN_generic_virtual_array.hh
409	Eek, thanks! The `GSpan` constructor seems to work better here anyway.

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)Oct 14 2021, 4:18 PM

Jacques Lucke (JacquesLucke) accepted this revision.Oct 14 2021, 4:24 PM

Jacques Lucke (JacquesLucke) added inline comments.

source/blender/functions/FN_generic_array.hh
30	Not sure if this comment really belongs here, seems unrelated to the entire file.
source/blender/functions/FN_generic_virtual_array.hh
409	Right. Note, if `GArray` would support small-object-optimization, then the `GSpan` constructor could not be used.