Fix T87526: Poor contrast in attribute search.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Apr 28 2021, 11:30 AM.

Details

Reviewers

Hans Goudey (HooglyBoogly)
Julian Eisel (Severin)

Maniphest Tasks

T87526: Poor contrast for right aligned grayed text in search menu active item

Commits

rB55590bf7a6e0: Fix T87526: poor contrast in attribute search

Summary

Before:

After:

The code that was changed here was introduced in rBe6d9d5dcc18f3ab55c31abc6bfb2010081538422. Hard to say if it has any unintended consequences, seems fine in my test.

Diff Detail

Repository

rB Blender

Branch

attribute-search-ui-cleanup (branched from master)

Build Status

Buildable 14272
Build 14272: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Apr 28 2021, 11:30 AM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B14272: Diff 36595.Apr 28 2021, 11:30 AM

Jacques Lucke (JacquesLucke) retitled this revision from Fix T87526 to Fix T87526: Poor contrast in attribute search..Apr 28 2021, 11:35 AM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Apr 28 2021, 11:37 AM

Jacques Lucke (JacquesLucke) added reviewers: Hans Goudey (HooglyBoogly), Julian Eisel (Severin).

Jacques Lucke (JacquesLucke) added a task: T87526: Poor contrast for right aligned grayed text in search menu active item.

Hans Goudey (HooglyBoogly) accepted this revision.Apr 28 2021, 2:02 PM

This revision is now accepted and ready to land.Apr 28 2021, 2:02 PM

Closed by commit rB55590bf7a6e0: Fix T87526: poor contrast in attribute search (authored by Jacques Lucke (JacquesLucke)). · Explain WhyApr 28 2021, 3:03 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB55590bf7a6e0: Fix T87526: poor contrast in attribute search.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

interface/

interface_region_search.c

3 lines

Diff 36595

View Options

source/blender/editors/interface/interface_region_search.c

Fix T87526: Poor contrast in attribute search.ClosedPublicActions