Cycles: removed unnecessary (redundant) multiplications in area lights importance sampling
ClosedPublic
Actions

Authored by Matteo Falduto (matteolegna) on Apr 29 2021, 4:23 AM.

Details

Reviewers

Commits

rCe10844d25881: Cleanup: removed unnecessary multiplications in area light importance sampling
rB8b9b87aee8e5: Cleanup: removed unnecessary multiplications in area light importance sampling

Summary

I believe those two multiplications that cancel out each other can be safely removed. Additionally, this makes the parameters new_len_u and new_len_v semantically consistent with len_u and len_v.

Diff Detail

Repository

rB Blender

Branch

importance_sampling (branched from master)

Build Status

Buildable 14295
Build 14295: arc lint + arc unit

Event Timeline

Matteo Falduto (matteolegna) requested review of this revision.Apr 29 2021, 4:23 AM

Matteo Falduto (matteolegna) created this revision.

Harbormaster completed remote builds in B14295: Diff 36632.Apr 29 2021, 4:23 AM

Matteo Falduto (matteolegna) edited the summary of this revision. (Show Details)Apr 29 2021, 4:30 AM

Matteo Falduto (matteolegna) added a project: Render & Cycles.

Brecht Van Lommel (brecht) accepted this revision.Apr 29 2021, 3:05 PM

This revision is now accepted and ready to land.Apr 29 2021, 3:05 PM

Closed by commit rB8b9b87aee8e5: Cleanup: removed unnecessary multiplications in area light importance sampling (authored by Matteo Falduto (matteolegna), committed by Brecht Van Lommel (brecht)). · Explain WhyApr 29 2021, 3:59 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB8b9b87aee8e5: Cleanup: removed unnecessary multiplications in area light importance sampling.

Stefan Werner (swerner) added a commit: rCe10844d25881: Cleanup: removed unnecessary multiplications in area light importance sampling.Jun 2 2021, 9:18 PM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

kernel/

kernel_light_common.h

8 lines

Diff 36632

View Options

intern/cycles/kernel/kernel_light_common.h

Cycles: removed unnecessary (redundant) multiplications in area lights importance samplingClosedPublicActions