Page MenuHome
Differential D11124

Fix T86450: Random User Interface Colour Change (regression)
ClosedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Apr 30 2021, 9:15 AM.

Details

Reviewers
Clément Foucault (fclem)
Maniphest Tasks
T86450: Random User Interface Colour Change (2.91+ Regression?)
Summary

Resolves an occasional glitch/flicker drawing the interface.

Regression in 405a5d3bd7ada5dd5af605b59ba07c7144f144a2
which removed shader unbinding when the batch is drawn.

GPU_shader_bind could running with the srgb uniform in an unexpected state.

To reproduce the bug, see: T86450#1154108 (I couldn't reproduce the steps in the original report).

Diff Detail

Repository
rB Blender
Branch
T (branched from master)
Build Status
Buildable 14318
Build 14318: arc lint + arc unit

Event Timeline

Campbell Barton (campbellbarton) requested review of this revision.Apr 30 2021, 9:15 AM
Campbell Barton (campbellbarton) created this revision.
Harbormaster completed remote builds in B14318: Diff 36672.Apr 30 2021, 9:15 AM
Campbell Barton (campbellbarton) added a task: T86450: Random User Interface Colour Change (2.91+ Regression?).Apr 30 2021, 9:16 AM
Campbell Barton (campbellbarton) retitled this revision from Fix T86450: Random User Interface Colour Change (2.91+ Regression?) to Fix T86450: Random User Interface Colour Change (regression).
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Apr 30 2021, 9:42 AM
Campbell Barton (campbellbarton) added a reviewer: Clément Foucault (fclem).
Campbell Barton (campbellbarton) added a project: EEVEE & Viewport.
Campbell Barton (campbellbarton) added inline comments.
source/blender/gpu/intern/gpu_shader.cc
507–512

The change to run GPU_matrix_bind in the else block wont cause issues as the first call clears the dirty flag.

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Apr 30 2021, 10:02 AM
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Apr 30 2021, 10:05 AM
Clément Foucault (fclem) accepted this revision.May 1 2021, 12:49 AM
This revision is now accepted and ready to land.May 1 2021, 12:49 AM
Campbell Barton (campbellbarton) mentioned this in rBb7f3ebe014a2: Fix T86450: Random dark UI elements when redrawing.May 1 2021, 4:13 PM
Campbell Barton (campbellbarton) closed this revision.Aug 4 2021, 1:03 PM

Committed rBb7f3ebe014a2

Revision Contents
Changeset List

PathSize
source/
blender/
gpu/
intern/
24 lines

Diff 36672

View Options

source/blender/gpu/intern/gpu_shader.cc

Loading...