Hide 3D Cursor in Paint Modes (with exceptions)
ClosedPublic
Actions

Authored by Julian Eisel (Severin) on Feb 15 2015, 5:20 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Antonis Ryakiotakis (psy-fi)

Commits

rBS0294327615bb: Hide 3D Cursor in Paint Modes (with exceptions)
rB0294327615bb: Hide 3D Cursor in Paint Modes (with exceptions)

Summary

Hide 3D Cursor in Paint Modes (with exceptions)

In paint modes, the 3D Cursor mostly is rather useless so it's more annoying than useful. This patch aims to hide the cursor in cases it's not used.

Included exceptions (cases where cursor is drawn in paint modes):

Active object is in weight paint mode and a selected bone in pose mode can be found
Clone brush (only if Clone from paint slot is disabled)

There might be more exceptions where the cursor should be shown in paint modes, but those are all I could find for now. Feel free to hint me for more.

Note: After D1110 was rejected, Campbell and me discussed this a bit more on IRC and agreed that this behaviour might be a good solution.

Diff Detail

Event Timeline

Julian Eisel (Severin) updated this revision to Diff 3534.Feb 15 2015, 5:20 PM

Julian Eisel (Severin) updated this revision to Diff 3539.

Julian Eisel (Severin) retitled this revision from to Hide 3D Cursor in Paint Modes (with exceptions).

Julian Eisel (Severin) updated this object.

Julian Eisel (Severin) added a reviewer: Campbell Barton (campbellbarton).

Julian Eisel (Severin) added a reviewer: Antonis Ryakiotakis (psy-fi).

Julian Eisel (Severin) set the repository for this revision to rB Blender.

Julian Eisel (Severin) added a project: User Interface.

Not sure if it's good to use NA_SELECTED for brush changes, but using NA_EDITED would mean we had to use ED_region_tag_redraw instead of ED_region_tag_redraw_overlay and I guess this would be much slower. I'm all ears for alternatives.

Antonis Ryakiotakis (psy-fi) added inline comments.Feb 15 2015, 7:07 PM

source/blender/editors/space_view3d/space_view3d.c
834	In instead of catching this notifier (which will fire on too many other cases), you can fire two different notifiers for the relevant property.
source/blender/editors/space_view3d/view3d_draw.c
3610	You must check the active paint mode as well, not only the tool. Probably should only be checked if there is an active object.
3616	Nope, we should draw by default.

Campbell Barton (campbellbarton) requested changes to this revision.Feb 15 2015, 9:21 PM

Campbell Barton (campbellbarton) edited edge metadata.

Campbell Barton (campbellbarton) added inline comments.

source/blender/editors/space_view3d/view3d_draw.c
3583	Could be called only when you know the objects in paint mode.
3595–3605	This should be a direct check. searching over all objects is overkill (If we _had_ to do this, then I'd rather just not have the functionality). But theres no need for it Instead check `(BKE_object_pose_armature_get(ob) != NULL)`