Fix T87983: Motion tracker button tooltips identical
ClosedPublic
Actions

Authored by Falk David (filedescriptor) on May 3 2021, 11:48 AM.

Details

Reviewers

Bastien Montagne (mont29)

Maniphest Tasks

T87983: Motion tracker tooltips identical for different buttons

Commits

rBb24b197cec04: Fix T87983: Motion tracker button tooltips identical

Summary

The tooltips for the tracker buttons were all equal (because they all
use the same operator).

This adds the get_description operator callback to the
CLIP_OT_track_markers operator and returns a more descriptive
tooltip for the different buttons.

Diff Detail

Repository: rB Blender

Event Timeline

Falk David (filedescriptor) requested review of this revision.May 3 2021, 11:48 AM

Falk David (filedescriptor) created this revision.

Harbormaster completed remote builds in B14340: Diff 36724.May 3 2021, 11:48 AM

Think this is great to finally distinguish the tooltips. However, I think the strings need to use TIP_ helper. Although, not really my area of expertise. Bastien will know the best!

Add TIP_ for translations.

Harbormaster completed remote builds in B14346: Diff 36731.May 3 2021, 3:30 PM

Indeed TIP_ is mandatory here. Besides picky note about UI messages style, looks fine.

source/blender/editors/space_clip/tracking_ops_track.c
410	We try to avoid third person in UI message, just stick to the infinitive (without the 'to', so imperative?) form: `Track the selected...` See also https://wiki.blender.org/wiki/Style_Guide/C_Cpp#UI_Messages Same below of course.