Page MenuHome
Differential D11151

VSE: Set view transform based on strip colorspace
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on May 4 2021, 4:38 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Maniphest Tasks
T86622: View Transform -> Filmic adds 333% to VSE render time and miscolors the result.
Commits
rB9576612d45dc: VSE: Set view transform based on strip colorspace
Summary

In some cases, users start video editing work from General template,
where Filmic view transform is chosen by default. Currently, this causes
issue when working with sRGB footage, which are not properly decoded
into linear working space and final render looks miscolored.

When adding first strip, check it's colorspace and if it corresponds to
colorspace for byte images, ensure that view transform is set to
default value, which is Standard.

Diff Detail

Repository
rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.May 4 2021, 4:38 AM
Richard Antalik (ISS) created this revision.
Harbormaster completed remote builds in B14354: Diff 36745.May 4 2021, 4:38 AM
Richard Antalik (ISS) mentioned this in D11149: Colormanagement: Skip view transform for byte images.May 4 2021, 4:39 AM
Brecht Van Lommel (brecht) accepted this revision.May 4 2021, 4:30 PM
This revision is now accepted and ready to land.May 4 2021, 4:30 PM
Closed by commit rB9576612d45dc: VSE: Set view transform based on strip colorspace (authored by Richard Antalik (ISS)). · Explain WhyMay 5 2021, 7:22 AM
This revision was automatically updated to reflect the committed changes.
Richard Antalik (ISS) added a commit: rB9576612d45dc: VSE: Set view transform based on strip colorspace.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_sequencer/
46 lines
sequencer/
1 line
intern/
21 lines

Diff 36790

View Options

source/blender/editors/space_sequencer/sequencer_add.c

Loading...
View Options

source/blender/sequencer/SEQ_add.h

Loading...
View Options

source/blender/sequencer/intern/strip_add.c

Loading...