Page MenuHome
Differential D11159

Fix T86314: materials not updated correctly after collada import (again)
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on May 4 2021, 3:23 PM.

Details

Reviewers
Gaia Clary (gaiaclary)
Jacques Lucke (JacquesLucke)
Maniphest Tasks
T86314: materials not updated correctly after collada import
Commits
rBa1069b6c662f: Fix T86314: materials not updated correctly after collada import (again)
Summary

While rB6b18678e34bf did the correct updates, it did it a bit early (not
covering all possible node tree changes).

Now do the ntreeUpdateTree() at the very end of the material import
instead.

Thx @Scurest (scurest) investigating.

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.May 4 2021, 3:23 PM
Philipp Oeser (lichtwerk) created this revision.
Harbormaster completed remote builds in B14368: Diff 36761.May 4 2021, 3:23 PM
Philipp Oeser (lichtwerk) added projects: Collada, Import/Export, Nodes.May 4 2021, 3:23 PM
Jacques Lucke (JacquesLucke) accepted this revision.May 5 2021, 2:48 PM

Haven't tested it myself, but the change looks safe and makes sense.

This revision is now accepted and ready to land.May 5 2021, 2:48 PM
Closed by commit rBa1069b6c662f: Fix T86314: materials not updated correctly after collada import (again) (authored by Philipp Oeser (lichtwerk)). · Explain WhyMay 6 2021, 8:44 AM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rBa1069b6c662f: Fix T86314: materials not updated correctly after collada import (again).

Revision Contents
Changeset List

PathSize
source/
blender/
io/
collada/
2 lines
2 lines
9 lines

Diff 36819

View Options

source/blender/io/collada/DocumentImporter.cpp

Loading...
View Options

source/blender/io/collada/Materials.h

Loading...
View Options

source/blender/io/collada/Materials.cpp

Loading...