Page MenuHome

Alembic Procedural: basic cache control settings
ClosedPublic

Authored by Kévin Dietrich (kevindietrich) on May 4 2021, 4:11 PM.

Details

Summary

This adds a setting to enable data caching, and another one to set the
maximum cache size in megabytes.

When caching is enabled we load the data for the entire animation in
memory, as we already do, however, if the data exceeds the memory limit,
render is aborted.

When caching is disabled, we simply load the data for the current frame
in memory.

Depends on D10197.

Diff Detail

Repository
rB Blender
Branch
abc_proc_cache_control (branched from master)
Build Status
Buildable 14375
Build 14375: arc lint + arc unit

Event Timeline

Kévin Dietrich (kevindietrich) requested review of this revision.May 4 2021, 4:11 PM
Kévin Dietrich (kevindietrich) created this revision.
Brecht Van Lommel (brecht) requested changes to this revision.May 11 2021, 10:39 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/editors/interface/interface_templates.c
7279–7284

Only show this if the Cycles procedural is enabled.

source/blender/makesdna/DNA_cachefile_types.h
100–103

Add a comment explaining this is for the Cycles procedural only at this point.

source/blender/makesrna/intern/rna_cachefile.c
155

Booleans should start with use_ instead of enable_, by convention.

Also I think using the term "prefetch" would be more consistent with Blender terminology and more precise. We use that term in the video sequencer.

So I suggest:

use_prefetch
prefetch_cache_size

With clear indication in the description that this is for the procedural.

This revision now requires changes to proceed.May 11 2021, 10:39 PM
  • revise UI to only show controls when the procedural is used
  • rename "cache" to "prefetch"
  • add comment
This revision is now accepted and ready to land.May 25 2021, 3:17 PM