Alembic Procedural: basic cache control settings
ClosedPublic
Actions

Authored by Kévin Dietrich (kevindietrich) on May 4 2021, 4:11 PM.

Details

Reviewers

Commits

rC9a6f04892311: Alembic Procedural: basic cache control settings
rB9bfc47c9334b: Alembic Procedural: basic cache control settings

Summary

This adds a setting to enable data caching, and another one to set the
maximum cache size in megabytes.

When caching is enabled we load the data for the entire animation in
memory, as we already do, however, if the data exceeds the memory limit,
render is aborted.

When caching is disabled, we simply load the data for the current frame
in memory.

Depends on D10197.

Diff Detail

Repository

rB Blender

Branch

abc_proc_cache_control_D11163 (branched from master)

Build Status

Buildable 14612
Build 14612: arc lint + arc unit

Event Timeline

Kévin Dietrich (kevindietrich) requested review of this revision.May 4 2021, 4:11 PM

Kévin Dietrich (kevindietrich) created this revision.

Harbormaster completed remote builds in B14375: Diff 36772.May 4 2021, 4:11 PM

Brecht Van Lommel (brecht) requested changes to this revision.May 11 2021, 10:39 PM

Brecht Van Lommel (brecht) added inline comments.

source/blender/editors/interface/interface_templates.c
7282–7287	Only show this if the Cycles procedural is enabled.
source/blender/makesdna/DNA_cachefile_types.h
98–105	Add a comment explaining this is for the Cycles procedural only at this point.
source/blender/makesrna/intern/rna_cachefile.c
155	Booleans should start with `use_` instead of `enable_`, by convention. Also I think using the term "prefetch" would be more consistent with Blender terminology and more precise. We use that term in the video sequencer. So I suggest: use_prefetch prefetch_cache_size With clear indication in the description that this is for the procedural.