Details

Reviewers

Jacques Lucke (JacquesLucke)

Maniphest Tasks

T88006: Switch node polishing

Commits

rB653bbaa246e3: Geometry Nodes: Polish switch node UI

Summary

Based on the task T88006, there are a few simple changes to make to improve the switch node

Change the label to "False" / "True" for clarity
Change default to geometry, as it's the basic data container in geometry nodes
Change node header to NODE_CLASS_CONVERTOR, which was an oversight in the original patch

I will add the new socket types (material and texture) in a separate commit.

Thanks to @Eitan Traurig (EitanSomething) for the original patch.

Diff Detail

Repository

rB Blender

Branch

switch_polishing (branched from master)

Build Status

Buildable 14380
Build 14380: arc lint + arc unit

Event Timeline

Eitan Traurig (EitanSomething) requested review of this revision.May 4 2021, 9:44 PM

Eitan Traurig (EitanSomething) created this revision.

Harbormaster completed remote builds in B14379: Diff 36784.May 4 2021, 9:44 PM

Eitan Traurig (EitanSomething) edited the summary of this revision. (Show Details)May 4 2021, 9:58 PM

Eitan Traurig (EitanSomething) added a project: Geometry Nodes.

Eitan Traurig (EitanSomething) edited the summary of this revision. (Show Details)

Eitan Traurig (EitanSomething) edited the summary of this revision. (Show Details)May 4 2021, 10:03 PM

Charlie Jolly (charlie) mentioned this in T86749: Geometry Node Community Additions.May 4 2021, 10:15 PM

You can use version_node_socket_name to version node links for the change. I guess you can just copy that into versioning_300.c

Add versioning

As far as I can tell I did everything right but it hangs when I open a file from the current version of 3.0 with a switch node.

Harbormaster completed remote builds in B14380: Diff 36786.May 5 2021, 12:51 AM

Thanks! It doesn't hang for me in my testing. Could you look into that a little more? Maybe pause execution with a debugger to see where it's stuck?

I would just commit this but I'd like to figure out what's happening for you first.

source/blender/blenloader/intern/versioning_300.c
72	For me this requires `#include <string.h>` at the top of this file.
115	New lines before and after this block

This revision is now accepted and ready to land.May 7 2021, 6:25 AM

Hans Goudey (HooglyBoogly) added a task: T88006: Switch node polishing.May 7 2021, 2:25 PM

@Eitan Traurig (EitanSomething) can you share the .blend

I am using a lite, would that affect anything? I will test it on a more complete build later today to see if that makes a difference.

TestCrash.blend813 KBDownload

The issue is that the versioning code does not fix all sockets. Remember that there are _001, ... sockets

source/blender/blenloader/intern/versioning_300.c
72	For me too.

This revision now requires changes to proceed.May 10 2021, 1:26 PM

In D11165#286414, @Jacques Lucke (JacquesLucke) wrote:

The issue is that the versioning code does not fix all sockets. Remember that there are _001, ... sockets

How would I go about fixing that?

How would I go about fixing that?

Not sure if that is the cleanest way, but you could just create a version of version_node_socket_name that works based on prefixes instead of exact names.

Eitan Traurig (EitanSomething) edited the summary of this revision. (Show Details)May 20 2021, 4:53 PM

@Eitan Traurig (EitanSomething) hi. If this is something you can't handle, try to get help from other developers from the community, or unclaim the original task, so someone else can pick it up.

In D11165#291860, @Dalai Felinto (dfelinto) wrote:

@Eitan Traurig (EitanSomething) hi. If this is something you can't handle, try to get help from other developers from the community, or unclaim the original task, so someone else can pick it up.

I currently don't have time to work on it so someone in the community can pick it up

Hans Goudey (HooglyBoogly) commandeered this revision.May 28 2021, 3:33 PM

Hans Goudey (HooglyBoogly) edited reviewers, added: Eitan Traurig (EitanSomething); removed: Hans Goudey (HooglyBoogly).

Hans Goudey (HooglyBoogly) removed reviewers: Dalai Felinto (dfelinto), Eitan Traurig (EitanSomething).

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)May 28 2021, 3:35 PM

Add versioning code for the rest of the socket names

Harbormaster completed remote builds in B14830: Diff 37606.May 28 2021, 3:36 PM

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)May 28 2021, 3:37 PM

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)

Hans Goudey (HooglyBoogly) added a subscriber: Eitan Traurig (EitanSomething).

Hans Goudey (HooglyBoogly) marked an inline comment as done.May 28 2021, 3:45 PM