Page MenuHome

Fix T82002: ENTER does not save/open file when mouse cursor is over Save dialog text field
AbandonedPublic

Authored by Philipp Oeser (lichtwerk) on May 5 2021, 5:42 PM.

Details

Summary

Caused by rB4ba9d7d71e8f: Fix fast clicks on File Browser sort columns not changing sorting.

Above commit was meant to prevent file.execute() for double-clicks
outside the file list [in order to allow fast clicks on the sort
columns], but effectively did this for all events [so ENTER / RETURN was
not working anymore when the mouse was over the text field].

This is usually where your mouse is when saving, forcing the user to
move the mouse, which is quite annoying.

Diff Detail

Repository
rB Blender
Branch
T82002 (branched from master)
Build Status
Buildable 14391
Build 14391: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.May 5 2021, 5:42 PM
Philipp Oeser (lichtwerk) created this revision.
Julian Eisel (Severin) requested changes to this revision.May 5 2021, 7:35 PM

It's the keymap that defines double-click to trigger FILE_OT_execute(), the operator shouldn't assume that's the case. Otherwise custom keymaps can break.
E.g. old Blender versions would open the active file when double-clicking empty space, some users may have set it up to do that still. There would be no way to do that anymore.

There are multiple things we could do. But I think it's best to separate the window level execute operator from the double-click execute operator. They'd share the same logic mostly. I already started looking into that, I can finish it if you want?

This revision now requires changes to proceed.May 5 2021, 7:35 PM

I already started looking into that, I can finish it if you want?

Yeah, please do.