Page MenuHome

UI Papercut: Improve Popover arrow position
AbandonedPublic

Authored by Leon Schittek (lone_noel) on May 5 2021, 11:13 PM.

Details

Reviewers
None
Group Reviewers
User Interface
Summary

This patch improves the popover triangle position by allowing the arrow to be drawn directly at the rounded corner.
This helps with an edge case, where the arrow of the properties panel’s settings popover isn’t drawn under the button but next to it, because it can’t be positioned closer to the popover’s edge.

currentpatch

Limitations
While this patch helps with this corner case happening with the default theme, similar situations can still occur when the button that’s emitting the popover is partially off-screen or the theme uses a large roundness for the menu back.

button partially off-screenhigh roundness value

Diff Detail

Repository
rB Blender
Branch
ui-improve-popover-triangle-position (branched from master)
Build Status
Buildable 14397
Build 14397: arc lint + arc unit

Event Timeline

Leon Schittek (lone_noel) requested review of this revision.May 5 2021, 11:13 PM
Leon Schittek (lone_noel) created this revision.
Leon Schittek (lone_noel) added projects: User Interface, Restricted Project.

There is already a similar patch D9865 with some discussion.

There is already a similar patch D9865 with some discussion.

Oh, I totally overlooked that one. Thanks for pointing it out!
I see that the problem has been thoroughly explored already and my patch doesn’t add anything new.