Clamp cycles preview area to camera bounds when passepartout is set to 1
ClosedPublic
Actions

Authored by Colin Marmond (Kdaf) on May 6 2021, 2:24 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)

Group Reviewers

Render & Cycles

Commits

rB25316ef9d735: Cycles: optimize 3D viewport rendering with camera passepartout

Summary

When the user is in camera view and the camera passepartout is set to 1, the rendering region of cycles should be only the visible area. This little patch create borders when the camera passepartout is set to 1. It allows a bit of performance improvements for those who will work with passepartout set to 1.

Diff Detail

Repository

rB Blender

Branch

test (branched from master)

Build Status

Buildable 14433
Build 14433: arc lint + arc unit

Event Timeline

Colin Marmond (Kdaf) requested review of this revision.May 6 2021, 2:24 PM

Colin Marmond (Kdaf) created this revision.

Harbormaster completed remote builds in B14411: Diff 36830.May 6 2021, 2:24 PM

Colin Marmond (Kdaf) retitled this revision from Clamp render area to camera borders when passepartout is set to 1 to Clamp cycles preview area to camera bounds when passepartout is set to 1.May 6 2021, 2:28 PM

Colin Marmond (Kdaf) edited the summary of this revision. (Show Details)

Colin Marmond (Kdaf) added a project: Cycles.

Colin Marmond (Kdaf) added a project: Render & Cycles.May 6 2021, 7:58 PM

Juan Gea (juang3d) awarded a token.May 6 2021, 9:22 PM

Fran Marz (franMarz) awarded a token.May 6 2021, 10:19 PM

Remove useless line

Harbormaster completed remote builds in B14433: Diff 36863.May 7 2021, 2:39 PM

Pratik Borhade (PratikPB2123) added a reviewer: Render & Cycles.May 9 2021, 1:29 PM

Daniel Salazar (zanqdo) awarded a token.May 13 2021, 5:25 AM

Raimund Klink (Raimund58) added a subscriber: Raimund Klink (Raimund58).May 14 2021, 11:18 AM

There are some minor things we can address before committing the change, but overall I think is a good and useful improvement.
Not sure if @Brecht Van Lommel (brecht) wants to have a pass of review here as well?

Sergey Sharybin (sergey) requested changes to this revision.May 17 2021, 6:40 PM

Sergey Sharybin (sergey) added inline comments.

intern/cycles/blender/blender_camera.cpp
913–914	After more careful read this actually seems problematic in the following scenario: go to camera view in viewport draw a border go to the render settings and disable border render hit F12 (probably even viewport render will not be correct either)

This revision now requires changes to proceed.May 17 2021, 6:40 PM

Sorry, disregard the previous comment. Was confused between Camera, BlenderCamera, and BL::Camera. From testing it seems to work fine.
Wouldn't mind second pair of eyes though.

This revision now requires review to proceed.May 18 2021, 9:51 AM

Colin Marmond (Kdaf) marked an inline comment as done.May 27 2021, 1:20 PM

Brecht Van Lommel (brecht) accepted this revision.May 31 2021, 6:39 PM

This revision is now accepted and ready to land.May 31 2021, 6:39 PM

Closed by commit rB25316ef9d735: Cycles: optimize 3D viewport rendering with camera passepartout (authored by Brecht Van Lommel (brecht)). · Explain WhyMay 31 2021, 7:24 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB25316ef9d735: Cycles: optimize 3D viewport rendering with camera passepartout.