Hi @Peter Carter (pjc7287) thanks for the new test cases.
But :(
You didn't take into account the comments and feedback given on your last patch. D10723

I will re-iterate.

In the python file:
There are formatting issues with poke, reveal, solidify and split (you don't have to break the line, the char limit is 120)

In the blend file:
You need to place the objects alphabetically in order of their collection names and order the collections alphabetically as well in the Outliner.

All tests are passing for me, except convex_hull (I think that might be because I am on Lite build, will investigate further later)

This revision now requires changes to proceed.May 9 2021, 8:30 PM

Formatting changes as requested by @Himanshi Kalra (calra) . Apologies for not fixing sooner, I misunderstood which parts needed formatting fixes. Let me know if the changes look right.

Additionally I've updated the operators.blend file so that the collections and meshes are all alphabetically sorted. A question I've been meaning to ask - is there an exactness to what the mesh coordinates are supposed to be? I've tried to maintain whatever pattern I noticed in the file...

Also , convex_hull runs and passes on my build. Let me know if there is something I need to fix about this.

Peter Carter (pjc7287) updated this revision to Diff 36956.May 11 2021, 1:37 AM

This comment was removed by Peter Carter (pjc7287).

Fixed missing formatting change in some operators

Himanshi Kalra (calra) mentioned this in T84999: Add Operator tests.May 11 2021, 3:30 PM

is there an exactness to what the mesh coordinates are supposed to be?

Afaik, no there isn't a fixed distance between objects. Purely from observation, from a zoomed out level, one blender cell contains approximately 2 sets of tests.

This patch LGTM
I tested it in a normal build (non-Lite), convex_hull seems to be working fine here.

Thank you for your contribution!

This revision is now accepted and ready to land.May 11 2021, 3:46 PM

Note for the person who commits it:
I think it would be good to mention a comment above convex_hull like "WITH_BULLET flag should be enabled while testing."

Testing from a fresh build from today's master (with WITH_BULLET enabled) I'm getting a few problems:

I can't apply the patch cleanly. Rebasing on latest master and submitting with arc should solve the problem. To test the patch I added the new tests manually.
Tests CubeConvexHull and MonkeyConvexHull are failing with error: 'Loop Vert Mismatch In Poly Test'

Can you reproduce any of those problems?

Requesting changes since some tests are not passing on latest master on macOS

This revision now requires changes to proceed.May 14 2021, 11:15 AM

I can confirm the patch is not applying cleanly. Clang cleanup by Campbell, see rBc1c0b661c01 (some unwanted accidental changes by my last commit)

All tests are passing on Windows 10 (Lite Build) as of latest master.rBbd5bab961e

rebase

Harbormaster completed remote builds in B14975: Diff 37881.Jun 4 2021, 8:28 PM

Could you rebase on latest master so that we can proceed with testing and review? Thanks

This revision now requires changes to proceed.Sep 5 2021, 12:28 PM

Add regression test for seven operators
Needs RevisionPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 36955

tests/python/operators.py

Add regression test for seven operatorsNeeds RevisionPublicActions