Page MenuHome
Differential D11210

RigidBodies: Clarify usage of the custom density in the calculate mass operator
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on May 10 2021, 10:43 AM.

Details

Reviewers
Sebastian Parborg (zeddb)
Maniphest Tasks
T88155: Calculate Mass: Operator Panel cannot adjust density
Commits
rBf432b5ccf5c1: RigidBodies: Clarify usage of the custom density in the calculate mass
Summary

This is only used when the preset is set to 'Custom', make that clear in
the tooltip and disable editing the value if a preset is used.

Issue came up in T88155.

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.May 10 2021, 10:43 AM
Philipp Oeser (lichtwerk) created this revision.
Harbormaster completed remote builds in B14461: Diff 36920.May 10 2021, 10:43 AM
Philipp Oeser (lichtwerk) mentioned this in T88155: Calculate Mass: Operator Panel cannot adjust density.May 10 2021, 10:44 AM
Pratik Borhade (PratikPB2123) added a project: Nodes & Physics.May 11 2021, 2:24 AM
Philipp Oeser (lichtwerk) added a project: User Interface.May 12 2021, 9:57 AM
Philipp Oeser (lichtwerk) added a reviewer: Sebastian Parborg (zeddb).May 14 2021, 1:26 PM
Philipp Oeser (lichtwerk) added a subscriber: Sebastian Parborg (zeddb).

Maybe @Sebastian Parborg (zeddb) can review?

Sebastian Parborg (zeddb) added a comment.EditedMay 14 2021, 3:37 PM

Hmm, I would actually disable (grey out) the density input field when "Custom" is not selected.
You can see how I did this for the quadriflow remesh menus:
blender/editors/object/object_remesh.c: quadriflow_poll_property

In that example, if the operator is not in "face mode" the face count input box is greyed out and can't have its values changed.
But the number of faces it will create is still updated and displayed.

I would think the same thing should happen here but with the density field.

Philipp Oeser (lichtwerk) updated this revision to Diff 37105.May 14 2021, 4:36 PM

disable editing density if a preset is used

Harbormaster completed remote builds in B14566: Diff 37105.May 14 2021, 4:36 PM
Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)May 14 2021, 4:37 PM
Sebastian Parborg (zeddb) accepted this revision.May 14 2021, 5:33 PM

LGTM! :)

This revision is now accepted and ready to land.May 14 2021, 5:33 PM
Closed by commit rBf432b5ccf5c1: RigidBodies: Clarify usage of the custom density in the calculate mass (authored by Philipp Oeser (lichtwerk)). · Explain WhyMay 15 2021, 2:55 AM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rBf432b5ccf5c1: RigidBodies: Clarify usage of the custom density in the calculate mass.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
physics/
23 lines

Diff 37128

View Options

source/blender/editors/physics/rigidbody_object.c

Loading...