Page MenuHome

Fix T88188: Keyframing Vertex Mass in Cloth Simulation doesn't have any effect
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on May 11 2021, 12:55 PM.

Details

Summary

The way it is now, ClothVertex->mass is used once in
cloth_from_object / do_init_cloth, where SIM_cloth_solver_init /
SIM_mass_spring_set_vertex_mass are called and set up masses in
Implicit_Data.
The masses from Implicit_Data are accessed in many places, so it would
be mandatory to have these masses kept up-to-date (and even then I am
unsure if the solver was designed to work with this animated? Or if
there are assumptions about this being stable across the sim?)

Seems possible to update ClothVertex->mass every step in
do_step_cloth, however it seems more involved to update the masses in
Implicit_Data there as well?
Also not sure about possible scenarios to check/verify this would
actually work as expected in all scenarios?
(left commented in the patch, to be removed prior to commiting)

So propose to remove the (broken/not implemented) animation capabilities
on the property instead.

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.May 11 2021, 12:55 PM
Philipp Oeser (lichtwerk) created this revision.

I think you can just clear the animatable property as you said.

I don't think you need to add the comment about it in cloth.c if we simply just toggle of the animatable flag.

I think you can just clear the animatable property as you said.

I don't think you need to add the comment about it in cloth.c if we simply just toggle of the animatable flag.

Yeah, comment will go prior to landing.
Does this mean green light from you?

This revision is now accepted and ready to land.May 12 2021, 5:57 PM