Page MenuHome
Differential D11226

Nodes: move shader curves node to C++
ClosedPublic
Actions

Authored by Charlie Jolly (charlie) on May 11 2021, 1:35 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Ray Molenkamp (LazyDodo)
Commits
rB6c2c16b5f87e: Nodes: move shader curves node to C++
Summary

Prepare node for conversion to Geometry Nodes.

There should be no functional changes.

Diff Detail

Repository
rB Blender

Event Timeline

Charlie Jolly (charlie) requested review of this revision.May 11 2021, 1:35 PM
Charlie Jolly (charlie) created this revision.
Harbormaster completed remote builds in B14501: Diff 36983.May 11 2021, 1:35 PM
Charlie Jolly (charlie) mentioned this in D10992: Geometry Nodes: Add Shader Curve Nodes.May 11 2021, 1:36 PM
Jacques Lucke (JacquesLucke) added a reviewer: Ray Molenkamp (LazyDodo).May 11 2021, 2:24 PM
Jacques Lucke (JacquesLucke) added a subscriber: Ray Molenkamp (LazyDodo).

@Ray Molenkamp (LazyDodo) please check if that introduces any compilation errors on your side, thanks :)

Ray Molenkamp (LazyDodo) accepted this revision.May 13 2021, 4:56 PM

Builds and passes tests on all platforms.

This revision is now accepted and ready to land.May 13 2021, 4:56 PM
Jacques Lucke (JacquesLucke) accepted this revision.May 13 2021, 10:49 PM

Thanks!

Closed by commit rB6c2c16b5f87e: Nodes: move shader curves node to C++ (authored by Charlie Jolly (charlie)). · Explain WhyMay 24 2021, 1:04 PM
This revision was automatically updated to reflect the committed changes.
Charlie Jolly (charlie) added a commit: rB6c2c16b5f87e: Nodes: move shader curves node to C++.

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
2 lines
shader/
nodes/
node_shader_curves.cc
node_shader_curves.c
8 lines

Diff 37418

View Options

source/blender/nodes/CMakeLists.txt

Loading...
View Options

source/blender/nodes/shader/nodes/node_shader_curves.c

Loading...
View Options

source/blender/nodes/shader/nodes/node_shader_curves.cc

Loading...