Page MenuHome
Differential D1122

BGE: Fix T41570: Blender crash when physics createConstraint
ClosedPublic
Actions

Authored by Jorge Bernal (lordloki) on Feb 18 2015, 7:36 AM.

Details

Reviewers
Campbell Barton (campbellbarton)
Martijn Berger (juicyfruit)
Dalai Felinto (dfelinto)
Mitchell Stokes (moguri)
Inês Almeida (brita_)
Commits
rBS9bd2a7c0a8ff: BGE: Fix T41570: Blender crash when physics createConstraint
rB9bd2a7c0a8ff: BGE: Fix T41570: Blender crash when physics createConstraint
Summary

Move physicsid type to unsigned long long to avoid crashes on Windows 8.1 64bits.
Other systems also modified to put them inline with this solution.

Diff Detail

Repository
rB Blender
Branch
bge-bug-create-constrain

Event Timeline

Jorge Bernal (lordloki) updated this revision to Diff 3563.Feb 18 2015, 7:36 AM
Jorge Bernal (lordloki) retitled this revision from to BGE: Fix T41570: Blender crash when physics createConstraint.
Jorge Bernal (lordloki) added reviewers: Dalai Felinto (dfelinto), Inês Almeida (brita_), Campbell Barton (campbellbarton), Mitchell Stokes (moguri).
Jorge Bernal (lordloki) updated this object.
Jorge Bernal (lordloki) mentioned this in T41570: Blender crash when physics createConstraint.Feb 18 2015, 7:41 AM
Campbell Barton (campbellbarton) accepted this revision.Feb 18 2015, 9:20 AM
Campbell Barton (campbellbarton) edited edge metadata.

Looks good.

source/gameengine/Ketsji/KX_PyConstraintBinding.cpp
521

*picky*, when editing code would add spaces after , - generally make in Blender's code style.

This revision is now accepted and ready to land.Feb 18 2015, 9:20 AM
Martijn Berger (juicyfruit) accepted this revision.Feb 18 2015, 10:39 AM
Martijn Berger (juicyfruit) added a reviewer: Martijn Berger (juicyfruit).
Martijn Berger (juicyfruit) added a subscriber: Martijn Berger (juicyfruit).

Fix and cleanup in one. Looks good to me

Jorge Bernal (lordloki) updated this revision to Diff 3569.Feb 18 2015, 7:50 PM
Jorge Bernal (lordloki) edited edge metadata.
  • style change
Closed by commit rB9bd2a7c0a8ff: BGE: Fix T41570: Blender crash when physics createConstraint (authored by Jorge Bernal (lordloki)). · Explain WhyFeb 18 2015, 7:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
gameengine/
Ketsji/
14 lines
39 lines

Diff 3563

View Options

source/gameengine/Ketsji/KX_GameObject.cpp

Loading...
View Options

source/gameengine/Ketsji/KX_PyConstraintBinding.cpp

Loading...