This patch adds an option in the Layers > Relations panel called "Disable Masks in Render".
When checked, no masks on this layer are included in the render.
Example:
 |  |
See T88202 for why this is needed.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- T88202 (branched from master)
- Build Status
Buildable 14513 Build 14513: arc lint + arc unit
Event Timeline
Comment Actions
I do not totally agree with this change. I see the situation when you filter by viewlayer and you want the only color or only shadow... but maybe some users can understand that you are filltering the main layer only and that masking layers are just "attributes" of the layer as the opacity or tint color.
I'm not sure if we must add an option to keep old mode and add this as an special option for some composition cases (something like filter masking layers or something like that)
@Matias Mendiola (mendio) @Daniel Martinez Lara (pepeland) What do you think?
Comment Actions
- Revert "Fix T88202: Layer masks render in viewlayer"
- Add option to disable masks for view layer
| source/blender/draw/engines/gpencil/gpencil_cache_utils.c | ||
|---|---|---|
| 278 ↗ | (On Diff #37026) | Hm, looks right to me |
Comment Actions
Code side LGTM.
I would like a review of @Daniel Martinez Lara (pepeland) and @Matias Mendiola (mendio) about functionality. Maybe @Samuel Bernou (Pullup) could test it.
Comment Actions
I tested the patch, the behavior mask disabled (Disable masks in Render checked) is working as expected.
But I believe the behavior with the mask enabled (Disable masks in Render unchecked) is subject to discuss...
I'd like to have more inputs, but in my opinion it should show the mask "applyed" without "color" appearing at all on layer shadow.
Like this (test made by @Falk David (filedescriptor)) :
Edit : Maybe the discussion about the "mask enabled" behavior should be considered a different task altogether, since the subject here is the new "Option to disable mask", which is OK.