Page MenuHome

Fix T88237: Prefetch crash on rendering scene strip
ClosedPublic

Authored by Richard Antalik (ISS) on May 13 2021, 6:37 PM.

Details

Summary

Prefetch needs to avoid rendering scene strips, because

  • Rendering in background needs own dependency graph, which fails to initialize from evaluated data.
  • This locks UI and can make it unresponsive for long time periods.

In T88237 prefetch failed to avoid scene strip, because of effect strip was attached to scene strip.

Ensure, that no effect that is attached to scene strip either directly or indirectly would be rendered.

Diff Detail

Repository
rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.May 13 2021, 6:37 PM
Richard Antalik (ISS) created this revision.
Richard Antalik (ISS) edited the summary of this revision. (Show Details)Aug 10 2021, 2:52 AM
  • Rebase on master, cleanup
  • Fix crash when scene strip is used as modifier mask
  • Free dataFix unfreed memory
Richard Antalik (ISS) edited the summary of this revision. (Show Details)Aug 12 2021, 5:23 PM
Richard Antalik (ISS) retitled this revision from Fix for T88237 to Fix T88237: Prefetch crash on rendering scene strip.Aug 12 2021, 5:38 PM
This revision is now accepted and ready to land.Aug 13 2021, 5:05 PM