Page MenuHome

GPencil: fix separate points/strokes freezing with empty selection
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on May 14 2021, 1:24 PM.

Details

Summary

Code would still create an ob (without setting up materials), code for
removing unused material slots would the freeze.

Now return/cancel early in case of empty selection.

This came up in T88269 [which is still not fully fixed, transforming
curve edit points clear their GP_STROKE_SELECT flag which now results in
the early exit, should be looked at separately]

Diff Detail

Repository
rB Blender
Branch
T88269 (branched from master)
Build Status
Buildable 14559
Build 14559: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.May 14 2021, 1:24 PM

make checking empty selection utility functions (breaks loops earlier)

Thanks for updating it to use a function +1
LGTM!

This revision is now accepted and ready to land.May 14 2021, 3:18 PM