Page MenuHome
Differential D11256

Fix T88234: Crash with Eevee when shader displacement socket connection is muted
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on May 14 2021, 3:47 PM.

Details

Reviewers
Clément Foucault (fclem)
Brecht Van Lommel (brecht)
Maniphest Tasks
T88234: Crash with Eevee when shader displacement socket connection is muted
Commits
rBd4a36c7ad55b: Fix T88234: Crash with Eevee when shader displacement socket connection is muted
Summary

In rB266cd7bb82ce: Nodes: Add support to mute node wires, support for muting links was added. It might be
debatable if we define a shader as "having" displacement even if the link
is muted, but after said commit, shader_has_displacement() would return
true but still leave the returned node as NULL.

Now also return false if the link is muted (otherwise the caller would
need to additionally check the returned node as well.)

Diff Detail

Repository
rB Blender
Branch
T88234 (branched from master)
Build Status
Buildable 14561
Build 14561: arc lint + arc unit

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
shader/
4 lines

Diff 37094

View Options

source/blender/nodes/shader/node_shader_tree.c

Loading...