Details

Reviewers

Commits

rB11e32332ddfd: Geometry Nodes: Add Mesh to Curve Node

Summary

This node creates curve splines from mesh edges. A selection attribute
input allows only using some of the edges from the input mesh. The node
builds cyclic splines from branchless groups of edges where possible,
but when there is a three-way intersection, the spline stops.

The algorithm is from Animation Nodes, written by @Omar Emara (OmarSquircleArt).
(find the original pull request here). I added the selection and used different variable
names, etc, but other that the algorithm is the same (in general the way AN
handles splines is fairly similar to node splines in Blender).

Diff Detail

Repository

rB Blender

Branch

geometry-nodes-curve-from-edges (branched from master)

Build Status

Buildable 14829
Build 14829: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.May 15 2021, 6:31 AM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B14581: Diff 37129.May 15 2021, 6:31 AM

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)May 15 2021, 6:36 AM

Hans Goudey (HooglyBoogly) added a reviewer: Jacques Lucke (JacquesLucke).

Hans Goudey (HooglyBoogly) added a project: Geometry Nodes.

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)

Leon Schittek (lone_noel) awarded a token.May 15 2021, 7:08 AM

Some User (someuser) awarded a token.May 15 2021, 9:24 AM

HEYPictures (HEYPictures) awarded a token.May 15 2021, 9:46 AM

Charlie Jolly (charlie) mentioned this in T86749: Geometry Node Community Additions.May 15 2021, 11:02 PM

Hans Goudey (HooglyBoogly) retitled this revision from Geometry Nodes: Curve from Edges Node to Geometry Nodes: Add Curve from Edges Node.May 16 2021, 2:21 AM

Fran Marz (franMarz) awarded a token.May 17 2021, 9:21 AM

Even without supporting dynamic attributes on curves, I should check if there are tilt or radius attributes on the mesh and copy them over.

Gregory (Apofis) awarded a token.May 18 2021, 3:16 PM

Gregory (Apofis) added a subscriber: Gregory (Apofis).

Merge branch 'master' into geometry-nodes-curve-from-edges
Copy tilt and radius attributes from mesh

Harbormaster completed remote builds in B14632: Diff 37225.May 18 2021, 11:58 PM

Something is wrong here, not sure what it is. The edges on the side are missing when the curve is converted to a mesh with a profile.

mesh_to_curve_test.blend785 KBDownload

Also, the default radius should probably not be zero.

This revision now requires changes to proceed.May 19 2021, 4:51 PM

Interesting, that's a bug with normals calculation, because of the stupid way I chose to calculate Z up normals. I'll look into that, but it's a separate problem.

Has there been any discussion on the naming? Curve from Edges, Edges to Curve, Mesh to Curve, ...

Also got a crash when using an Attribute Fill node after the Curve from Edges node (P2132). Just insert an attribute name in the Attribute Fill node in this file:

curve_to_mesh.blend786 KBDownload

Jacques Lucke (JacquesLucke) added inline comments.May 21 2021, 1:17 PM

source/blender/nodes/geometry/nodes/node_geo_curve_from_edges.cc
77 ↗	(On Diff #37225)	This can be done now.

Deen (Bit) awarded a token.May 21 2021, 5:01 PM

Rename node to curve to mesh, copy mesh attributes

Harbormaster completed remote builds in B14769: Diff 37488.May 25 2021, 10:30 PM

Hans Goudey (HooglyBoogly) retitled this revision from Geometry Nodes: Add Curve from Edges Node to Geometry Nodes: Add Mesh to Curve Node.May 25 2021, 10:30 PM

Jacques Lucke (JacquesLucke) added inline comments.May 28 2021, 1:41 PM

source/blender/nodes/geometry/nodes/node_geo_mesh_to_curve.cc
93	This assert is hit for me when I have a mesh without faces that has a face attribute. Example: face_attribute_bug.blend774 KBDownload I think the fix is to remove this from `MeshComponent::attribute_try_adapt_domain`: if (varray->size() == 0) { return {}; } Does that sound fine to you?
183	typo (`edges`)

Merge branch 'master' into geometry-nodes-curve-from-edges
Fix type, add null attribute check

Harbormaster completed remote builds in B14829: Diff 37605.May 28 2021, 2:49 PM

Hans Goudey (HooglyBoogly) added inline comments.May 28 2021, 3:11 PM

source/blender/nodes/geometry/nodes/node_geo_mesh_to_curve.cc
93	I think that would be fine. Not necessarily better though, and in this case I'd rather not add such attributes at all. Since they don't contain any data, they are like "ghost" attributes. I just added the check here.

Jacques Lucke (JacquesLucke) accepted this revision.May 28 2021, 3:34 PM

Jacques Lucke (JacquesLucke) added inline comments.

source/blender/nodes/geometry/nodes/node_geo_mesh_to_curve.cc
93	If we don't add these attributes, we have to be more careful with error messages. Afaik we still often get error messages for attributes that would be there if we wouldn't "optimize" them away.. Personally, I'm not so sure about the fact that these "ghost attributes" are bad, they make things more predictable imo.

This revision is now accepted and ready to land.May 28 2021, 3:34 PM

Closed by commit rB11e32332ddfd: Geometry Nodes: Add Mesh to Curve Node (authored by Hans Goudey (HooglyBoogly)). · Explain WhyMay 28 2021, 4:43 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB11e32332ddfd: Geometry Nodes: Add Mesh to Curve Node.

Duarte Farrajota Ramos (duarteframos) awarded a token.May 29 2021, 12:00 AM

Amal Kumar (amalbubble) awarded a token.Jun 12 2021, 10:37 AM

Geometry Nodes: Add Mesh to Curve Node
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 37605

release/scripts/startup/nodeitems_builtins.py

source/blender/blenkernel/BKE_node.h

source/blender/blenkernel/intern/node.cc

source/blender/nodes/CMakeLists.txt

source/blender/nodes/NOD_geometry.h

source/blender/nodes/NOD_static_types.h

source/blender/nodes/geometry/nodes/node_geo_mesh_to_curve.cc

Geometry Nodes: Add Mesh to Curve NodeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37605

release/scripts/startup/nodeitems_builtins.py

source/blender/blenkernel/BKE_node.h

source/blender/blenkernel/intern/node.cc

source/blender/nodes/CMakeLists.txt

source/blender/nodes/NOD_geometry.h

source/blender/nodes/NOD_static_types.h

source/blender/nodes/geometry/nodes/node_geo_mesh_to_curve.cc

Geometry Nodes: Add Mesh to Curve Node
ClosedPublic
Actions

Revision Contents
Changeset List