Page MenuHome
Differential D11269

Group FCurves by bone name when importing from FBX or BVH
ClosedPublic
Actions

Authored by Nils Hasler (nils.hasler) on May 16 2021, 2:44 AM.

Details

Reviewers
Bastien Montagne (mont29)
Group Reviewers
Add-ons (BF-Blender)
Maniphest Tasks
T82472: Importing animation does not create channel groups
Commits
rBAa2c3cfdd764b: Group FCurves by bone name when importing from FBX or BVH
Summary

When importing an animation from FBX or BVH the fcurves are currently shown as a very long list in the dope sheet.

When you manually create a keyframe they are grouped by bone name, which is much more user friendly. This patch groups imported animations by bone name too.

The changes are trivial:

  • In the FBX case it was falsely using the object name to group all curves rather than the bone name.
  • The BVH importer simply wasn't using the grouping feature at all.

Diff Detail

Repository
rBA Blender Add-ons
Branch
GroupFCurvesByBoneWhenImporting
Build Status
Buildable 14586
Build 14586: arc lint + arc unit

Event Timeline

Nils Hasler (nils.hasler) requested review of this revision.May 16 2021, 2:44 AM
Nils Hasler (nils.hasler) created this revision.
Harbormaster completed remote builds in B14586: Diff 37144.May 16 2021, 2:44 AM
Nils Hasler (nils.hasler) edited the summary of this revision. (Show Details)May 16 2021, 2:52 AM
Nils Hasler (nils.hasler) edited the summary of this revision. (Show Details)
Nils Hasler (nils.hasler) added a reviewer: Add-ons (BF-Blender).May 16 2021, 3:00 AM
Scurest (scurest) added a subscriber: Scurest (scurest).May 16 2021, 3:11 AM

This fixes T82472.

Scurest (scurest) mentioned this in D11023: FBX import: group fcurves by bone name.May 16 2021, 3:12 AM
Gaia Clary (gaiaclary) added a reviewer: Bastien Montagne (mont29).May 16 2021, 10:52 PM
Gaia Clary (gaiaclary) added subscribers: Bastien Montagne (mont29), Gaia Clary (gaiaclary).

I find this is a useful improvement. @Bastien Montagne (mont29) i dare to add you as reviewer for this :)

Brad Clark (RiggingDojo) awarded a token.Dec 15 2021, 8:48 AM
Brad Clark (RiggingDojo) added a subscriber: Brad Clark (RiggingDojo).
Philipp Oeser (lichtwerk) added a task: T82472: Importing animation does not create channel groups.Mar 8 2022, 9:12 AM
Bastien Montagne (mont29) accepted this revision.Mar 8 2022, 4:16 PM

LGTM, thanks for the patch.

This revision is now accepted and ready to land.Mar 8 2022, 4:16 PM
Closed by commit rBAa2c3cfdd764b: Group FCurves by bone name when importing from FBX or BVH (authored by Nils Hasler (nils.hasler), committed by Bastien Montagne (mont29)). · Explain WhyMar 8 2022, 4:20 PM
This revision was automatically updated to reflect the committed changes.
Bastien Montagne (mont29) added a commit: rBAa2c3cfdd764b: Group FCurves by bone name when importing from FBX or BVH.
Brad Clark (RiggingDojo) added a comment.Mar 8 2022, 5:32 PM

This will be so great to have fixed!!

Revision Contents
Changeset List

PathSize
io_anim_bvh/
4 lines
io_scene_fbx/
2 lines

Diff 37144

View Options

io_anim_bvh/import_bvh.py

Loading...
View Options

io_scene_fbx/import_fbx.py

Loading...