Details

Reviewers

Commits

rBA823910c50d1c: VR: Default Actions, Controller Visualization

Summary

This updates the VR Scene Inspection add-on with functionality for
loading and using default controller actions, including controller
poses and haptics.

Users can choose whether to use default actions during a session via
a toggle in the "VR Session" panel. In addition, for controller
bindings that require OpenXR extensions (Reverb G2, Cosmos, Huawei),
there is an "Action Maps" panel to enable/disable these bindings.
Bindings that require extensions are disabled by default since not
all OpenXR runtimes may support them, which will lead to an error
during action creation.

In addition, this adds a "Viewport Feedback" option to draw VR
controllers as viewport gizmos. The gizmos consist of axes for the
controller aim components, as well as a spherical outline for the
grip components.

Diff Detail

Repository

rBA Blender Add-ons

Branch

vr-default-actions-controller-gizmos

Build Status

Buildable 16330
Build 16330: arc lint + arc unit

Event Timeline

Peter Kim (muxed-reality) requested review of this revision.May 16 2021, 8:49 AM

Peter Kim (muxed-reality) created this revision.

Harbormaster completed remote builds in B14588: Diff 37147.May 16 2021, 8:49 AM

Peter Kim (muxed-reality) edited the summary of this revision. (Show Details)May 16 2021, 8:55 AM

Peter Kim (muxed-reality) added reviewers: Julian Eisel (Severin), Dalai Felinto (dfelinto).

Peter Kim (muxed-reality) changed the visibility from "Public (No Login Required)" to "All Users".

Peter Kim (muxed-reality) added a project: Virtual Reality.

Peter Kim (muxed-reality) retitled this revision from VR: XR Action Creation and Controller Gizmo Visualization to VR Add-on: XR Action Creation and Controller Gizmo Visualization.May 16 2021, 8:57 AM

Peter Kim (muxed-reality) mentioned this in D10943: XR Actions [part 2]: Actionmaps.May 16 2021, 9:05 AM

Fran Marz (franMarz) awarded a token.May 17 2021, 9:27 AM

Peter Kim (muxed-reality) changed the visibility from "All Users" to "Public (No Login Required)".May 18 2021, 11:05 AM

Milan Košir (kosirm) awarded a token.May 22 2021, 12:48 AM

I don't quite see the point in the action-map editing UI this adds. I thought all this would be handled via Python scripts now (like the default.py)? The way the UI looks, we wouldn't accept it for core features as it's not really following existing UI conventions well enough. For add-ons we usually allow more freedom, but I'd still prefer to do a better job at it. It also looks quite technical & scary too :) I rather avoid showing such complexity to regular users.

Besides this I don't think we need to do a lot of review. So I'm not gonna spend much time digging into details.

I would split up the main.py file some more. Could be something like this:

__init__.py
gui.py
operators.py
action_map.py
action_map_io.py
properties.py (for all the landmark properties and callbacks)
versioning.py
defaults.py
configs/default.py

Remove action map editing, split up main file

Also update based on discussion, master commits
(rBe844e9e8f3bb, rBd3d4be1db3a0, rBfb1822ddeb28).

Harbormaster completed remote builds in B16330: Diff 40532.Aug 10 2021, 11:34 AM

Peter Kim (muxed-reality) retitled this revision from VR Add-on: XR Action Creation and Controller Gizmo Visualization to VR Add-on: Default Actions, Controller Gizmos.Aug 10 2021, 11:50 AM

Peter Kim (muxed-reality) edited the summary of this revision. (Show Details)

Add toggle for gamepad input

Harbormaster completed remote builds in B16394: Diff 40656.Aug 13 2021, 3:01 AM

Fix typo

Harbormaster completed remote builds in B16395: Diff 40657.Aug 13 2021, 3:06 AM

Peter Kim (muxed-reality) edited the summary of this revision. (Show Details)Aug 13 2021, 3:09 AM

Peter Kim (muxed-reality) mentioned this in rB5a0ec2302eeb: XR: Enable controller profile extensions.Aug 25 2021, 2:38 PM

Again, just a rough review, but I think that's fine. Left two simple suggestions.
We don't have to expect issues with committing this before D10949: XR Controller Support Step 7: Controller Based Picking and D10950: XR Controller Support Step 8: Controller Based Transform, right? (Like accessing undefined properties.)

viewport_vr_preview/__init__.py
51–55	I'd just add a `register()` and `unregister()` function to the module, so you can just do `gui.register()` here. You can follow the new Pose Library add-on here, e.g. check `pose_library/__init__.py` and `pose_library/gui.py`
88–130	Any reason for keeping these here? I though they would go to `properties.py`.

This revision is now accepted and ready to land.Aug 27 2021, 12:25 PM

Julian Eisel (Severin) removed a reviewer: Dalai Felinto (dfelinto).Aug 27 2021, 12:26 PM

Move class/property registration to appropriate files

Also replace "undo/redo" default actions with "toggle shading"
(solid, material preview).

Harbormaster completed remote builds in B16752: Diff 41318.Sep 1 2021, 10:47 AM

Remove unused classes list from __init__.py

Forgot to remove this in previous update.

Harbormaster completed remote builds in B16753: Diff 41319.Sep 1 2021, 10:52 AM

In D11271#320326, @Julian Eisel (Severin) wrote:

Again, just a rough review, but I think that's fine. Left two simple suggestions.
We don't have to expect issues with committing this before D10949: XR Controller Support Step 7: Controller Based Picking and D10950: XR Controller Support Step 8: Controller Based Transform, right? (Like accessing undefined properties.)

Yes, there won't be any issues since the only default actions at the moment are toggle solid/material preview (view3d.toggle_shading) as well as the actions for controller poses and haptics.
That being said, I think it's best to commit this after D11501: XR Controller Support Step 5: Navigation so we can add the default navigation actions.

viewport_vr_preview/__init__.py
51–55	Moved class/property registration to the different modules.

Peter Kim (muxed-reality) marked an inline comment as done.Sep 1 2021, 11:16 AM

Peter Kim (muxed-reality) mentioned this in D10944: XR Controller Support Step 3: XR Event Handling.Sep 4 2021, 3:46 AM

Update based on master (committed D10944, D10948)

Also add navigation operators from D11501.

Harbormaster completed remote builds in B17754: Diff 43189.Oct 12 2021, 11:29 AM

Julian Eisel (Severin) accepted this revision.Oct 12 2021, 11:47 AM

Bibin Abraham Jacob (JacAbraham) added a subscriber: Bibin Abraham Jacob (JacAbraham).Oct 13 2021, 7:45 AM

Paul Larson (GeorgiaPacific) added a subscriber: Paul Larson (GeorgiaPacific).Oct 19 2021, 3:43 AM

Peter Kim (muxed-reality) mentioned this in D11501: XR Controller Support Step 5: Navigation.Oct 24 2021, 12:23 AM

Add base scale property to landmarks

Similar to base pose location and angle, landmarks can have a reference
scale that the viewer can start the session at or return to during the
session.

This can only be edited in the UI for landmarks of type OBJECT and
CUSTOM (so not SCENE_CAMERA).

Harbormaster completed remote builds in B18156: Diff 43835.Oct 24 2021, 1:24 AM

Aaron Carlisle (Blendify) added a subscriber: Aaron Carlisle (Blendify).Oct 24 2021, 5:08 AM

Closed by commit rBA823910c50d1c: VR: Default Actions, Controller Visualization (authored by Peter Kim (muxed-reality)). · Explain WhyOct 26 2021, 6:46 AM

This revision was automatically updated to reflect the committed changes.

Peter Kim (muxed-reality) added a commit: rBA823910c50d1c: VR: Default Actions, Controller Visualization.

VR Add-on: Default Actions, Controller Gizmos
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 40532

viewport_vr_preview.py

viewport_vr_preview/init.py

viewport_vr_preview/action_map.py

viewport_vr_preview/action_map_io.py

viewport_vr_preview/configs/default.py

viewport_vr_preview/defaults.py

viewport_vr_preview/gui.py

viewport_vr_preview/operators.py

viewport_vr_preview/properties.py

viewport_vr_preview/versioning.py

VR Add-on: Default Actions, Controller GizmosClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40532

viewport_vr_preview.py

viewport_vr_preview/__init__.py

viewport_vr_preview/action_map.py

viewport_vr_preview/action_map_io.py

viewport_vr_preview/configs/default.py

viewport_vr_preview/defaults.py

viewport_vr_preview/gui.py

viewport_vr_preview/operators.py

viewport_vr_preview/properties.py

viewport_vr_preview/versioning.py

VR Add-on: Default Actions, Controller Gizmos
ClosedPublic
Actions

Revision Contents
Changeset List

viewport_vr_preview/init.py