Details

Reviewers

Sybren A. Stüvel (sybren)

Group Reviewers

Alembic

Maniphest Tasks

T88074: Alembic: export animated vertex colors

Commits

rB4e2478940eb8: Alembic: Allow exporting of animated vertex colors

Summary

This patch is for the task T88074

This patch changes the alembic writing of vertex colors to allow for animated vertex color exports.

The changes are made to be in line with the way the UV Maps are written.
Each vertex color gets a OC4fGeomParam created and mapped into the CDStreamConfig to avoid recreating the Param on each frame.

The time sample index is also stored in the config now and set onto the UV and Vertex Color params each frame. Without this the exports would get inconsistent timing results where animated UV maps and Vertex Colors were not playing back at the original speed.

Diff Detail

Repository

rB Blender

Branch

arcpatch-D11278 (branched from master)

Build Status

Buildable 18507
Build 18507: arc lint + arc unit

Event Timeline

Cody Winchester (CodyWinch) requested review of this revision.May 17 2021, 3:03 PM

Cody Winchester (CodyWinch) created this revision.

Cody Winchester (CodyWinch) added a task: T88074: Alembic: export animated vertex colors.

With recent changes in the Alembic exporter code, this patch no longer applies. Could you rebase it to the latest master?

Rebase

Rebase (with the correct diff this time)

Rebase

kursad k (kursadk) awarded a token.Oct 15 2021, 4:30 AM

Rebased on master, and clarified a comment

Harbormaster completed remote builds in B18507: Diff 44418.Nov 5 2021, 2:54 PM

Sybren A. Stüvel (sybren) added inline comments.Nov 5 2021, 2:58 PM

source/blender/io/alembic/intern/abc_customdata.h
86–87	I've changed this comment, so that it makes explicit what the `std::string` represents. Personally I always try to keep both keys and values of a map explicitly documented ("mapping from X to Y").