Differential D11282

Fix T88359: Issue of object matrix order use in pose bake
ClosedPublic
Actions

Authored by dreamertooth (dreamertooth) on May 17 2021, 11:15 PM.

Tags

Subscribers

None

Details

Reviewers

Sybren A. Stüvel (sybren)
Wayde Moss (GuiltyGhost)

Group Reviewers

Animation & Rigging

Maniphest Tasks

T88359: Bake of animation keyframes are fail when object is quaternion define but bones is Eular define

Commits

rBa1954e380730: Fix T86193: Bake Action, wrong rotation order for bones

Summary

This commit fixes T88359. rotation_mode use for matrix basis is change to mode of bone, not object of bone

Diff Detail

Repository: rB Blender

Event Timeline

dreamertooth (dreamertooth) requested review of this revision.May 17 2021, 11:15 PM

dreamertooth (dreamertooth) created this revision.

Harbormaster completed remote builds in B14609: Diff 37185.May 17 2021, 11:15 PM

Philipp Oeser (lichtwerk) added a project: Animation & Rigging.May 18 2021, 1:12 PM

Pratik Borhade (PratikPB2123) retitled this revision from fix issue of object matrix order use in pose bake to Fix T88359: Issue of object matrix order use in pose bake.May 18 2021, 2:01 PM

Wayde Moss (GuiltyGhost) mentioned this in T86193: Bake action result unexpected since 2.92.May 20 2021, 3:21 AM

Sybren A. Stüvel (sybren) added reviewers: Sybren A. Stüvel (sybren), Wayde Moss (GuiltyGhost), Animation & Rigging.May 20 2021, 12:13 PM

Sybren A. Stüvel (sybren) accepted this revision.May 20 2021, 12:47 PM

This revision is now accepted and ready to land.May 20 2021, 12:47 PM

For the record: @Wayde Moss (GuiltyGhost) tested this patch already and reported it fixes the issue (see T86193#1163188), so I've accepted it on behalf of the entire module even though he hasn't explicitly accepted this patch yet.

Closed by commit rBa1954e380730: Fix T86193: Bake Action, wrong rotation order for bones (authored by dreamertooth (dreamertooth), committed by Sybren A. Stüvel (sybren)). · Explain WhyMay 20 2021, 12:58 PM

This revision was automatically updated to reflect the committed changes.

Sybren A. Stüvel (sybren) added a commit: rBa1954e380730: Fix T86193: Bake Action, wrong rotation order for bones.

Revision Contents
Changeset List

Path

Size

release/

scripts/

modules/

bpy_extras/

2 lines

Diff 37306

release/scripts/modules/bpy_extras/anim_utils.py

Loading...