Page MenuHome
Differential D11292

Fix ineffective subdiv behavior in collection instances for line art
ClosedPublic
Actions

Authored by YimingWu (NicksBest) on May 18 2021, 4:46 PM.

Details

Reviewers
Antonio Vazquez (antoniov)
Group Reviewers
Grease Pencil
Summary

Does what the title says.

This new code handles OB_DUPLICOLLECTION correctly so it's able to add relation to the instanced object as well.

Diff Detail

Repository
rB Blender

Event Timeline

YimingWu (NicksBest) requested review of this revision.May 18 2021, 4:46 PM
YimingWu (NicksBest) created this revision.
YimingWu (NicksBest) mentioned this in T88362: Lineart countour rendering error (ignores subdivision modifiers?).
Antonio Vazquez (antoniov) accepted this revision.May 18 2021, 4:49 PM
Antonio Vazquez (antoniov) added a subscriber: Antonio Vazquez (antoniov).

I can see you just add the collection if is Empty and dupli group. Well done!

This revision is now accepted and ready to land.May 18 2021, 4:49 PM
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).May 18 2021, 5:01 PM
Philipp Oeser (lichtwerk) added inline comments.
source/blender/gpencil_modifiers/intern/MOD_gpencillineart.c
221

add_this_collection

can we get a better name?

also: why not use collection (instead of c) like everywhere else?

YimingWu (NicksBest) mentioned this in rB5239198f177a: Fix T88362: Lineart countour rendering error.May 19 2021, 9:10 AM
YimingWu (NicksBest) closed this revision.May 19 2021, 12:39 PM
YimingWu (NicksBest) marked an inline comment as done.
YimingWu (NicksBest) added inline comments.
source/blender/gpencil_modifiers/intern/MOD_gpencillineart.c
221

Humm this is just a very local utility function so the name doesn't really bring much problem. The scope is small enough.

Revision Contents
Changeset List

PathSize
source/
blender/
gpencil_modifiers/
intern/
28 lines

Diff 37208

View Options

source/blender/gpencil_modifiers/intern/MOD_gpencillineart.c

Loading...