Page MenuHome

Line Art feature update: Filtering intersection lines using mask numbers
ClosedPublic

Authored by YimingWu (NicksBest) on May 19 2021, 2:28 PM.

Details

Summary

This patch needs D11302 D11291 D11288 in place first!

Does what the title says. Mask value works just like transparency mask. You are able to select intersection lines inside a collection or, between collections.

Diff Detail

Repository
rB Blender

Event Timeline

Updated to only include isec code

Updated to latest master

Fix unintentional UI Changes

I'm getting an assert if I open the occlusion transparency panel:

BLI_assert failed: source/blender/makesrna/intern/rna_access.c:2480, RNA_property_boolean_get_index(), at 'index < len'

Seems like the masking in the collection settings are not working either as UI wise:

I talked to Jacques about the Masks. He thinks we should use a list bases instead to store "tags"
Then in the modifier you also have a list base where the user input tags that they want to use.

This way the user can use names and are not limited to 8 bit flags.

I talked to Jacques about the Masks. He thinks we should use a list bases instead to store "tags"
Then in the modifier you also have a list base where the user input tags that they want to use.

This way the user can use names and are not limited to 8 bit flags.

8 bit is the internal limit, because that variable has to be in every edge and triangle data structure, so we can't afford more (or to use list base for each of them during calculation). We can expose the setting as list though, so it gives the benefit of naming each bit or something like that...

But this way you got to keep a "master list" somewhere? That way we can then select "my flag", "another flag" from a list. So where to put it? under Scene?

I'm getting an assert if I open the occlusion transparency panel:

BLI_assert failed: source/blender/makesrna/intern/rna_access.c:2480, RNA_property_boolean_get_index(), at 'index < len'

UGHHH it should only have 6 bits now... And the UI, I haven't quite figured out how to make it horizontal like you do in python... I'll try

Fix UI display issue.

This flag thing is similar to the problem pointed out by D11308

Fixed with latest master

Fixed with latest master

Included a missing change in lineart_cpu.c

Updated with latest menu.

Other than my nitpick, LGTM.

source/blender/makesdna/DNA_gpencil_modifier_types.h
888

Did you mean to change this comment?
I think this is the older comment that we changed from before?

This revision is now accepted and ready to land.Jun 29 2021, 2:36 PM