Page MenuHome

T88369: Reduce locking of atomic counters.
AbandonedPublic

Authored by Jeroen Bakker (jbakker) on May 19 2021, 2:57 PM.

Details

Reviewers
None
Maniphest Tasks
T88369: DrawManager: Task counters atomics.
Summary

When multiple atomic operations happen in the same cache line by different threads, the
second thread will block until the cache cacheline is unlocked by the first. When multiple
counter share the same cache line this would add unexpected locks.

This patch changes that by moving each atomic counter in its own cache
line.

TODO

See if we can verify any difference.
Verify with cpu engineers.

Diff Detail

Repository
rB Blender
Branch
T88369-drawmanager-task-counters (branched from master)
Build Status
Buildable 14649
Build 14649: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.May 19 2021, 2:57 PM
Jeroen Bakker (jbakker) created this revision.
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)May 19 2021, 3:08 PM

Number of atomics are reduced in master (only one)