Fix T88411: Draw frame node text when label is empty
ClosedPublic
Actions

Authored by Leon Schittek (lone_noel) on May 19 2021, 11:28 PM.

Details

Reviewers

Pablo Vazquez (pablovazquez)

Group Reviewers

User Interface

Maniphest Tasks

T88411: Text in Frame's node won't render if Label is empty

Commits

rBac97893dfc77: Fix T88411: Draw frame node text when label is empty

Summary

This patch fixes the issue described in T88411, that the text in frame nodes is only shown, when the node has a label. This has been caused by rB8f04ddbbc626, because node_draw_frame_label not only draws the label, but also all the other text. Therefore skipping it, when the label is empty, also skips drawing the other text.
This is fixed by moving the check for the empty label into node_frame_draw_label.

Patch: Frame nodes show text despite not having a label.

Same setup in master:

Test file

frame_label_text_test.blend808 KBDownload

Diff Detail

Repository

rB Blender

Branch

fix-T88411-frame-node-text (branched from master)

Build Status

Buildable 16484
Build 16484: arc lint + arc unit

Event Timeline

Leon Schittek (lone_noel) requested review of this revision.May 19 2021, 11:28 PM

Leon Schittek (lone_noel) created this revision.

Harbormaster completed remote builds in B14657: Diff 37285.May 19 2021, 11:28 PM

Leon Schittek (lone_noel) edited the summary of this revision. (Show Details)May 19 2021, 11:34 PM

Leon Schittek (lone_noel) added reviewers: User Interface, Pablo Vazquez (pablovazquez).

Leon Schittek (lone_noel) added a project: User Interface.

Leon Schittek (lone_noel) mentioned this in T88411: Text in Frame's node won't render if Label is empty.May 19 2021, 11:36 PM

Philipp Oeser (lichtwerk) added a task: T88411: Text in Frame's node won't render if Label is empty.May 20 2021, 12:15 PM

Hi, thanks for the patch!

By looking at the image of the patch:

We should probably remove the padding on the top when there's no label too. Have you tried that?

I hadn't tested that, but I think it does look nice. If you prefer it without padding, as well, I'll update the patch accordingly.

Here's another comparison with a bit more text:

without padding	with padding

I think it looks better! No reason to have empty room for the label if there's none. Further tweaking can happen outside of this patch.

Cheers!

Remove padding when there's no label.

Harbormaster completed remote builds in B16484: Diff 40803.Aug 17 2021, 9:34 PM

Leon Schittek (lone_noel) edited the summary of this revision. (Show Details)Aug 17 2021, 9:36 PM

Ah much better, thanks!

This looks good to me, @Harley Acheson (harley) could you please give your blessings to the code? :D

@Harley Acheson (harley) gentle ping

In D11315#317902, @Pablo Vazquez (pablovazquez) wrote:

Ah much better, thanks!

This looks good to me, @Harley Acheson (harley) could you please give your blessings to the code? :D