Page MenuHome

Cleanup: Improve naming and documentation
Needs ReviewPublic

Authored by Richard Antalik (ISS) on May 20 2021, 4:20 AM.

Details

Summary

Function SEQ_ensure_unique_name has misleading name and insufficient
documentation.

Diff Detail

Repository
rB Blender
Branch
clearer_name (branched from master)
Build Status
Buildable 14662
Build 14662: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.May 20 2021, 4:20 AM
Richard Antalik (ISS) created this revision.
source/blender/sequencer/intern/utils.c
633

I am still a bit unsure why we do recursive call :(

Richard Antalik (ISS) marked an inline comment as done.May 24 2021, 5:10 AM
Richard Antalik (ISS) added inline comments.
source/blender/sequencer/intern/utils.c
633

You can duplicate metastrip and you need to ensure unique name for metastrip and children. Recursive here means: "do it for strip and it's children recursively".

It may be a bit redundant naming, but there are more similar "do_x_recursive" functions.

Or do you mean why don't we convert recursive function to linear one? I can do that with iterator, but it's not always possible and not always cleaner too.