Paths

Table of Contentst

GPencil: Fix missing annotations in VSE strip
ClosedPublic
Actions

Authored by Antonio Vazquez (antoniov) on May 20 2021, 6:15 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Matias Mendiola (mendio)

Group Reviewers

Grease Pencil
Video Sequencer

Commits

rBef04fd95717d: GPencil: Fix missing annotations in VSE strip

Summary

Since version 2.80, the annotations of the Scene strip were not displayed in VSE. Also, the UI panel was Grease Pencil and must be Annotation

The problem was the offscreen render hasn't evil_CTX and the section of the annotation was never called.

Test file:

VSE_annotation.blend785 KBDownload

Diff Detail

Repository: rB Blender

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.May 20 2021, 6:15 PM

Antonio Vazquez (antoniov) created this revision.

Harbormaster completed remote builds in B14672: Diff 37322.May 20 2021, 6:15 PM

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)May 20 2021, 6:16 PM

Antonio Vazquez (antoniov) added reviewers: Grease Pencil, Video Sequencer.

Antonio Vazquez (antoniov) added projects: Grease Pencil, Video Sequencer.

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)

Antonio Vazquez (antoniov) added a subscriber: Brecht Van Lommel (brecht).

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)May 20 2021, 6:19 PM

Cleanup: Fix comments

Harbormaster completed remote builds in B14673: Diff 37324.May 20 2021, 6:22 PM

Brecht Van Lommel (brecht) accepted this revision.May 20 2021, 7:27 PM

This revision is now accepted and ready to land.May 20 2021, 7:27 PM

Matias Mendiola (mendio) accepted this revision.May 20 2021, 8:13 PM

Closed by commit rBef04fd95717d: GPencil: Fix missing annotations in VSE strip (authored by Antonio Vazquez (antoniov)). · Explain WhyMay 20 2021, 8:17 PM

This revision was automatically updated to reflect the committed changes.

Antonio Vazquez (antoniov) added a commit: rBef04fd95717d: GPencil: Fix missing annotations in VSE strip.

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_ui/

space_sequencer.py

2 lines

source/

blender/

draw/

intern/

draw_manager.c

8 lines

makesdna/

DNA_sequence_types.h

4 lines

makesrna/

intern/

rna_sequencer.c

9 lines

sequencer/

intern/

render.c

2 lines

Diff 37327

View Options

release/scripts/startup/bl_ui/space_sequencer.py

View Options

source/blender/draw/intern/draw_manager.c

View Options

source/blender/makesdna/DNA_sequence_types.h

View Options

source/blender/makesrna/intern/rna_sequencer.c

View Options

source/blender/sequencer/intern/render.c

GPencil: Fix missing annotations in VSE stripClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37327

release/scripts/startup/bl_ui/space_sequencer.py

source/blender/draw/intern/draw_manager.c

source/blender/makesdna/DNA_sequence_types.h

source/blender/makesrna/intern/rna_sequencer.c

source/blender/sequencer/intern/render.c

GPencil: Fix missing annotations in VSE strip
ClosedPublic
Actions

Revision Contents
Changeset List