Page MenuHome
Differential D11332

Fix T81494 - Image Texture Node result shade as pink color
Needs ReviewPublic
Actions

Authored by Fabrício Luis (ce3po) on May 20 2021, 8:49 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Maniphest Tasks
T81494: Eevee: Image Texture Node: Switching the source from "Generated" to "Single Image" and back to "Generated" leaves the shader result as pink color
Summary

Fix T81494
When switching in Image Texture Node 'Single Image' to 'Generated' and after 'Generated' to 'Single Image' this shader result as pink color.

Solution
Created ima->last_filepath variable for save last filepath before switching to Generated. And back restore filepath
when change to Single_Image.
This ima->last_filepath variable avoid saving img->filepath and not affected other applications.
And the scope this variable only handled wher img->source equal generated image in BKE_image_signal function.

Diff Detail

Repository
rB Blender
Branch
Fix_T81494 (branched from master)
Build Status
Buildable 14676
Build 14676: arc lint + arc unit

Event Timeline

Fabrício Luis (ce3po) requested review of this revision.May 20 2021, 8:49 PM
Fabrício Luis (ce3po) created this revision.
Harbormaster completed remote builds in B14676: Diff 37331.May 20 2021, 8:49 PM
Fabrício Luis (ce3po) edited the summary of this revision. (Show Details)May 20 2021, 8:55 PM
Fabrício Luis (ce3po) edited the summary of this revision. (Show Details)May 20 2021, 8:59 PM
Fabrício Luis (ce3po) edited the summary of this revision. (Show Details)May 20 2021, 10:25 PM
Fabrício Luis (ce3po) retitled this revision from Fix T81494 to Fix T81494 - Image Texture Node result shade as pink color.May 20 2021, 10:40 PM
Pratik Borhade (PratikPB2123) added a task: T81494: Eevee: Image Texture Node: Switching the source from "Generated" to "Single Image" and back to "Generated" leaves the shader result as pink color.May 21 2021, 11:01 AM
Pratik Borhade (PratikPB2123) edited the summary of this revision. (Show Details)
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).May 21 2021, 11:03 AM

There is already a patch for this ticket (D9153)

Pratik Borhade (PratikPB2123) added a subscriber: Philipp Oeser (lichtwerk).May 21 2021, 11:09 AM

@Philipp Oeser (lichtwerk) , got any point for this patch ? you already have an alternative solution.

Philipp Oeser (lichtwerk) added a comment.May 21 2021, 4:38 PM
In D11332#290032, @Pratik Borhade (PratikPB2123) wrote:

@Philipp Oeser (lichtwerk) , got any point for this patch ? you already have an alternative solution.

I am always a bit paranoid on growing struct sizes on something as often used as Image, will have to check my solution again (soonish)

Fabrício Luis (ce3po) added a comment.EditedMay 21 2021, 6:26 PM
In D11332#290149, @Philipp Oeser (lichtwerk) wrote:
In D11332#290032, @Pratik Borhade (PratikPB2123) wrote:

@Philipp Oeser (lichtwerk) , got any point for this patch ? you already have an alternative solution.

I am always a bit paranoid on growing struct sizes on something as often used as Image, will have to check my solution again (soonish)

Thanks, @Philipp Oeser (lichtwerk) and @Pratik Borhade (PratikPB2123) for yours comments.
Is true, growing struct size is no good. I will go try find other solution, too.

Regards,

Fabrício Luis.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
9 lines
makesdna/
1 line

Diff 37331

View Options

source/blender/blenkernel/intern/image.c

Loading...
View Options

source/blender/makesdna/DNA_image_types.h

Loading...