Page MenuHome
Differential D11333

Make loopcut drawing consistent between gizmo and operator.
ClosedPublic
Actions

Authored by Anthony Edlin (krash) on May 21 2021, 12:48 AM.
Tags
Subscribers
None
Tokens
"Love" token, awarded by Raimund58."Love" token, awarded by gilberto_rodrigues."Love" token, awarded by iyadahmed2001."Love" token, awarded by Slowwkidd.

Details

Reviewers
Clément Foucault (fclem)
Group Reviewers
EEVEE & Viewport
Commits
rBb867df903fc8: Make loopcut drawing consistent between gizmo and operator.
Summary

Loopcut drawing from gizmo had thicker lines because
it was using line smoothing without alpha blend, compared
to thin jagged lines from operator.

Make the drawing anti aliased and consistent by using
3D_POLYLINE/3D_POINT shaders, and making sure alpha
blending is on.

Diff Detail

Repository
rB Blender

Event Timeline

Anthony Edlin (krash) requested review of this revision.May 21 2021, 12:48 AM
Anthony Edlin (krash) created this revision.
Harbormaster completed remote builds in B14678: Diff 37333.May 21 2021, 12:48 AM
Anthony Edlin (krash) added a comment.May 21 2021, 1:17 AM

Here are before and after of operator drawing:

Here is before and after of gizmo drawing:

slwk1d (Slowwkidd) awarded a token.May 21 2021, 12:09 PM
Iyad Ahmed (iyadahmed2001) awarded a token.May 21 2021, 1:31 PM
Iyad Ahmed (iyadahmed2001) added a reviewer: EEVEE & Viewport.May 21 2021, 1:39 PM
Iyad Ahmed (iyadahmed2001) added a project: EEVEE & Viewport.
Clément Foucault (fclem) accepted this revision.May 21 2021, 3:51 PM
This revision is now accepted and ready to land.May 21 2021, 3:51 PM
Closed by commit rBb867df903fc8: Make loopcut drawing consistent between gizmo and operator. (authored by Anthony Edlin (krash), committed by Jeroen Bakker (jbakker)). · Explain WhyAug 4 2021, 11:20 AM
This revision was automatically updated to reflect the committed changes.
Jeroen Bakker (jbakker) added a commit: rBb867df903fc8: Make loopcut drawing consistent between gizmo and operator..
Gilberto Rodrigues (gilberto_rodrigues) awarded a token.Aug 24 2021, 9:24 AM
Raimund Klink (Raimund58) awarded a token.Sep 21 2021, 1:44 PM
Jeroen Bakker (jbakker) mentioned this in rB96027b2d15b7: Make knife drawing anti aliased (Monkey work based on D11333).Sep 21 2021, 3:40 PM
Jeroen Bakker (jbakker) mentioned this in rB7633548d60cc: Revert "Make knife drawing anti aliased (Monkey work based on D11333)".Sep 22 2021, 1:51 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
mesh/
28 lines

Diff 40304

View Options

source/blender/editors/mesh/editmesh_preselect_edgering.c

Loading...