Fix T86465: Annotation Tool is missing in VSE Preview toolbar
ClosedPublic
Actions

Authored by Antonio Vazquez (antoniov) on May 21 2021, 6:04 PM.

Details

Reviewers

Matias Mendiola (mendio)
Daniel Martinez Lara (pepeland)

Maniphest Tasks

T86465: UI/Annotation: Annotation Tool is missing in VSE Preview toolbar and annotation note pop-up is also missing in sidebar.

Commits

rB0a83f32d79bc: Fix T86465: Annotation Tool is missing in VSE Preview toolbar

Summary

Added missing topbar in VSE.

Also added the Stabilizer options to Topbar for all modes.

Diff Detail

Repository

rB Blender

Branch

temp-annotation-vse (branched from master)

Build Status

Buildable 14693
Build 14693: arc lint + arc unit

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.May 21 2021, 6:04 PM

Antonio Vazquez (antoniov) created this revision.

Harbormaster completed remote builds in B14693: Diff 37358.May 21 2021, 6:04 PM

@Peter Fog (tintwotin) Could you test if this fix the issue?

This is the screen with this patch applied.

It is so much better now. Some of the questions/bugs mentioned, have I made gifs for, so it is hopefully more clear:

Why is the Annotation options both exposed as a Tool panel and as a View panel? Could the one in the View sidebar be removed?

Is onion skin missing from the tool settings?

If is is, should onion skin also be exposed in the tool header?

In Sequencer/Preview mode the mouse cursor changes into the pen in the area where you can't draw(the strip area), and if you try to draw in that area, a point will light up in the preview area:

(Maybe at some point an Annotation strip could even be introduced?)

Add Stabilize to Topbar

Harbormaster completed remote builds in B14714: Diff 37393.May 22 2021, 3:29 PM

Antonio Vazquez (antoniov) added a reviewer: Matias Mendiola (mendio).May 22 2021, 3:30 PM

Antonio Vazquez (antoniov) added a project: Grease Pencil.

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)

@Matias Mendiola (mendio) What do you think about this pending UI change?

Daniel Martinez Lara (pepeland) accepted this revision.May 26 2021, 4:41 PM

This revision is now accepted and ready to land.May 26 2021, 4:41 PM

@Antonio Vazquez (antoniov) @Matias Mendiola (mendio) Should I make additional bug reports for these issues mentioned here? https://developer.blender.org/D11347#290305

In D11347#291596, @Peter Fog (tintwotin) wrote:

@Antonio Vazquez (antoniov) @Matias Mendiola (mendio) Should I make additional bug reports for these issues mentioned here? https://developer.blender.org/D11347#290305

yes, the other changes affect not only the VSE but other areas of Blender where annotation is used. It is better to treat them separately

Peter Fog (tintwotin) mentioned this in T88616: GP/Annotation UI: The Annotation options are both exposed as a Tool panel and as a View panel.May 27 2021, 9:41 AM

@Antonio Vazquez (antoniov) @Matias Mendiola (mendio) Reports for the additional issues reported here: T88617 and T88616

Peter Fog (tintwotin) mentioned this in T88617: GP/Annotation UI: Wrong icon and behaviour in the wrong regions.May 27 2021, 12:19 PM

Matias Mendiola (mendio) accepted this revision.May 27 2021, 7:40 PM

Closed by commit rB0a83f32d79bc: Fix T86465: Annotation Tool is missing in VSE Preview toolbar (authored by Antonio Vazquez (antoniov)). · Explain WhyMay 27 2021, 7:54 PM

This revision was automatically updated to reflect the committed changes.

Antonio Vazquez (antoniov) added a commit: rB0a83f32d79bc: Fix T86465: Annotation Tool is missing in VSE Preview toolbar.