Page MenuHome
Differential D11352

Rigify UI changes
ClosedPublic
Actions

Authored by Daniel Salazar (zanqdo) on May 21 2021, 11:48 PM.
Tags
None
Subscribers
Brad Clark (RiggingDojo)
Demeter Dzadik (Mets)
Tokens
"Love" token, awarded by Mets."Love" token, awarded by Loner."Love" token, awarded by Stig."Love" token, awarded by RiggingDojo.

Details

Reviewers
Campbell Barton (campbellbarton)
Sybren A. Stüvel (sybren)
Alexander Gavrilov (angavrilov)
Aaron Carlisle (Blendify)
Commits
rBA84367c7d8e1c: Rigify UI: Make the layers start at 0 to match the real layer numbers, change…
Summary

Changes based on personal use and on conversation on the animation module channel

This adds the following changes

  • Make the rigify layer UI numbers start at 0 to match the bone layer numbering

  • Change the icons for adding and removing Rigify bone groups to regular + and - icons instead of the weird zoom in-out icons

Diff Detail

Event Timeline

Daniel Salazar (zanqdo) requested review of this revision.May 21 2021, 11:48 PM
Daniel Salazar (zanqdo) created this revision.
Daniel Salazar (zanqdo) added reviewers: Campbell Barton (campbellbarton), Sybren A. Stüvel (sybren), Alexander Gavrilov (angavrilov).May 22 2021, 12:10 AM
Daniel Salazar (zanqdo) edited the summary of this revision. (Show Details)May 22 2021, 12:20 AM
Brad Clark (RiggingDojo) awarded a token.May 22 2021, 2:00 AM
Brad Clark (RiggingDojo) added a subscriber: Brad Clark (RiggingDojo).

Thank you!

Aaron Carlisle (Blendify) accepted this revision.May 22 2021, 3:09 AM
This revision is now accepted and ready to land.May 22 2021, 3:09 AM
Stig Oskar (Stig) awarded a token.May 22 2021, 3:10 AM
Demeter Dzadik (Mets) added a subscriber: Demeter Dzadik (Mets).May 22 2021, 4:20 AM

+1 from me, riggers who use Rigify are smart enough to not be terrified by a 0-indexed list in the UI, and this makes it so much less frustrating to use the tooltips to know which layer is which.

Alexander Gavrilov (angavrilov) accepted this revision.May 29 2021, 10:01 PM

It seems everybody agrees on the changes, and there are no code problems.

Ruslan (Loner) awarded a token.May 30 2021, 2:07 PM
Daniel Salazar (zanqdo) updated this revision to Diff 50586.Apr 19 2022, 7:17 PM

Updates for latest Rigify version

Demeter Dzadik (Mets) added a comment.Apr 19 2022, 7:58 PM

Ah, I guess this is just waiting for someone with commit rights. I don't usually commit other people's patches, so let me just triple check with @Daniel Salazar (zanqdo) just to be 100% sure: Is this ready to commit? If so, since Alexander already gave it the green and is probably busy, I can go ahead and do it.

Daniel Salazar (zanqdo) mentioned this in rBA84367c7d8e1c: Rigify UI: Make the layers start at 0 to match the real layer numbers, change….Apr 19 2022, 10:25 PM
Daniel Salazar (zanqdo) closed this revision.Apr 19 2022, 10:37 PM
Daniel Salazar (zanqdo) added a commit: rBA84367c7d8e1c: Rigify UI: Make the layers start at 0 to match the real layer numbers, change….
Demeter Dzadik (Mets) added a comment.Apr 19 2022, 10:50 PM

You've got the power!

Demeter Dzadik (Mets) awarded a token.Apr 19 2022, 10:51 PM
Daniel Salazar (zanqdo) added a comment.Apr 20 2022, 2:31 AM
In D11352#394887, @Demeter Dzadik (Mets) wrote:

You've got the power!

SUCH POWER! 🔥

Revision Contents
Changeset List

PathSize
rigify/
6 lines

Diff 37371

View Options

rigify/ui.py

Loading...