Page MenuHome
Differential D11358

Fix for T88464: Updating line art camera with maker befor calculation
ClosedPublic
Actions

Authored by YimingWu (NicksBest) on May 22 2021, 2:36 PM.

Details

Reviewers
Sebastian Parborg (zeddb)
Antonio Vazquez (antoniov)
Group Reviewers
Grease Pencil
Commits
rB0a7bd3b6d24a: Fix T88464: Incorrect baking with camera markers.
Summary

Does what it says. Fix for T88464.

Diff Detail

Repository
rB Blender

Event Timeline

YimingWu (NicksBest) requested review of this revision.May 22 2021, 2:36 PM
YimingWu (NicksBest) created this revision.
Antonio Vazquez (antoniov) added a reviewer: Sebastian Parborg (zeddb).May 22 2021, 3:04 PM
Antonio Vazquez (antoniov) added subscribers: Sebastian Parborg (zeddb), Antonio Vazquez (antoniov).

@Sebastian Parborg (zeddb) Never used before this function, so maybe you can confirm this is the way to go or not.

Antonio Vazquez (antoniov) accepted this revision.May 24 2021, 12:45 PM

I have tested and this function does exactly what we need.

This revision is now accepted and ready to land.May 24 2021, 12:45 PM
Sebastian Parborg (zeddb) accepted this revision.May 24 2021, 3:41 PM

Dynamic paint and our fluid sim does this indirectly when baking by calling ED_update_for_newframe, so I guess this is fine.

Closed by commit rB0a7bd3b6d24a: Fix T88464: Incorrect baking with camera markers. (authored by YimingWu (NicksBest)). · Explain WhyMay 25 2021, 10:51 AM
This revision was automatically updated to reflect the committed changes.
YimingWu (NicksBest) added a commit: rB0a7bd3b6d24a: Fix T88464: Incorrect baking with camera markers..

Revision Contents
Changeset List

PathSize
source/
blender/
gpencil_modifiers/
intern/
lineart/
2 lines

Diff 37390

View Options

source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c

Loading...