Details

Reviewers

Sybren A. Stüvel (sybren)
Campbell Barton (campbellbarton)

Group Reviewers

Animation & Rigging

Commits

rB066f5a446954: Cleanup: pose slider rename region to region_header

Summary

split off from D11284

rename region to region_header

Diff Detail

Repository: rB Blender

Event Timeline

Christoph Lendenfeld (ChrisLend) requested review of this revision.May 22 2021, 9:35 PM

Christoph Lendenfeld (ChrisLend) created this revision.

Christoph Lendenfeld (ChrisLend) mentioned this in D11284: Cleanup Pose Slider code.May 22 2021, 9:41 PM

If the header isn't found the preview-slider could simply not draw (as it would do currently) - since showing the slider isn't necessary for full functionality of the operator.

This revision now requires changes to proceed.May 24 2021, 6:46 AM

I was overthinking that.
My reason was that it might be confusing if you can't see the slider, but a user is more likely to start the slider with the header visible and after running it once they know what to expect

Campbell Barton (campbellbarton) accepted this revision.Jun 2 2021, 6:48 PM

This revision is now accepted and ready to land.Jun 2 2021, 6:48 PM

There are a few changes that are different than just renaming a field. These changes are fine, but should be committed separately.

source/blender/editors/armature/pose_slide.c
486–492	This code move is not just "rename `region` to `region_header`", so it shouldn't be done in this patch.
1097	This is also a different change than "rename X to Y", so should be in a separate commit.