Does what the title says. Indeed a lot of times we don't want the stroke style being affected by lights, so here's the patch.
Details
Details
- Reviewers
Antonio Vazquez (antoniov) Pablo Vazquez (pablovazquez) - Group Reviewers
Grease Pencil - Commits
- rB45b28c0f8847: GPencil: Add a use_light option when creating object.
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
Actually... I changed the default value for line art use_lights to false to better reflect the usage.
Comment Actions
For me is ok this parameter, but I would like to hear the opinion of @Matias Mendiola (mendio) and @Pablo Vazquez (pablovazquez). My concern is to add too many parameters.
| source/blender/editors/object/object_add.c | ||
|---|---|---|
| 1532 | Default must be True | |
| source/blender/editors/object/object_add.c | ||
|---|---|---|
| 1436 | Here, you only need disable if required. By default the object is added with lights, so to have two times the ON lights code is not good. if (!use_lights) {
ob->dtx &= ~OB_USE_GPENCIL_LIGHTS;
} | |
| source/blender/editors/object/object_add.c | ||
|---|---|---|
| 1532 | This is only effective for adding line art object not everything else. I think it's fair to set it false? | |
| source/blender/editors/object/object_add.c | ||
|---|---|---|
| 1532 | And why this object must be different? I'm not a fan to have different settings for LineArt objects. | |
| source/blender/editors/object/object_add.c | ||
|---|---|---|
| 1532 | Humm... maybe the strokes aren't meant by styled by light in almost all use cases, and because the normal data will not be as desired anyway. | |
| source/blender/editors/object/object_add.c | ||
|---|---|---|
| 1532 | Ok, let's wait for @Matias Mendiola (mendio) @Pablo Vazquez (pablovazquez) opinion. | |
Comment Actions
@YimingWu (NicksBest) I have talked with Pablo and Matias and both agree to have different default settings for LineArt, so you can set Lights=OFF for LineArt by default. You can commit to master
Note: Remember to update release notes page (https://wiki.blender.org/wiki/Reference/Release_Notes/3.0/Grease_Pencil)