Page MenuHome

Fix (unreported): TextureOperation inputs have no resolution
ClosedPublic

Authored by Manuel Castilla (manzanilla) on May 25 2021, 2:14 PM.

Details

Summary

When compositor node tree has a texture node, TextureOperation vector inputs has always {0, 0} resolution instead of having same resolution as TextureOperation which is the expected behaviour for resolutions propagation.

Current TextureOperation determineResolution implementation doesn't determine inputs resolution, breaking propagation of preferred resolution and that's the reason why they are always 0. Setting scene resolution always would mean it is its own resolution and could make sense, but setting it only when preferred resolution is 0, breaks preferred resolution logic affecting other operations as explained in D10972. In any case scene resolution is already the default preferred resolution on viewer and compositor nodes.


Graphviz before patch:

Graphviz after patch:

Diff Detail

Repository
rB Blender

Event Timeline

Manuel Castilla (manzanilla) requested review of this revision.May 25 2021, 2:14 PM
Manuel Castilla (manzanilla) created this revision.
  • Force preferred resolution as TextureOperation resolution
This revision is now accepted and ready to land.May 31 2021, 9:20 AM