Page MenuHome
Differential D11390

Fix T87932: Failure to build movie strip proxy
AbandonedPublic
Actions

Authored by Sebastian Parborg (zeddb) on May 25 2021, 5:40 PM.

Details

Reviewers
None
Summary

We didn't initialize the scaled proxy frame properly.
This would lead to issues in ffmpeg 4.4 as they are more strict that the API is properly used.

Now we initialize the size and format of the frame.

Diff Detail

Event Timeline

Sebastian Parborg (zeddb) requested review of this revision.May 25 2021, 5:40 PM
Sebastian Parborg (zeddb) created this revision.
Sebastian Parborg (zeddb) mentioned this in T87932: Failure to build movie strip proxy / ffmpeg incompatibility.
Sebastian Parborg (zeddb) edited the summary of this revision. (Show Details)May 25 2021, 9:29 PM
Richard Antalik (ISS) added a subscriber: Richard Antalik (ISS).May 26 2021, 10:54 AM
Richard Antalik (ISS) added inline comments.
source/blender/imbuf/intern/indexer.c
599

Can you link to resource that require this? also it would be best to document why it's needed in code, because similar code for height was removed, because it was causing performance issues in rB4fd73e746553

Sebastian Parborg (zeddb) added inline comments.May 26 2021, 11:00 AM
source/blender/imbuf/intern/indexer.c
599

Ah I just refactored the code a bit. I can just remove this part then?
I'm guessing it is the same faulty reasoning as in the other part that you cleaned up.

Sebastian Parborg (zeddb) updated this revision to Diff 37505.May 26 2021, 11:23 AM
Sebastian Parborg (zeddb) marked an inline comment as done.May 26 2021, 11:27 AM

Talked to richard on blender.chat. The round_up code was there to work around issues not in ffmpeg 4.4 we can remove it.

Sebastian Parborg (zeddb) abandoned this revision.May 28 2021, 6:36 PM

I've merged this to master.

Revision Contents
Changeset List

PathSize
source/
blender/
imbuf/
intern/
11 lines

Diff 37471

View Options

source/blender/imbuf/intern/indexer.c

Loading...