Page MenuHome
Differential D11404

Outliner: use 'compacted' row for bones as well
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on May 26 2021, 5:05 PM.

Details

Reviewers
Julian Eisel (Severin)
Bastien Montagne (mont29)
Sybren A. Stüvel (sybren)
Maniphest Tasks
T88413: Armature: Bone dependency tree does not highlight selected bone deep enough
Commits
rBb6a35a8153c3: Outliner: use 'compacted' row for bones as well
Summary

In a collapsed hierarchy, some type of data are listed as one icon per item (2.79 did this for all data),
others are 'compacted' as a single icon with a counter (also indicating if the active item is down that collapsed hierarchy) from 2.80 on.

Not quite sure if rB92dfc8f2673e: Outliner: regroup more type of entries under a single icon. was meant to do this (if it was, this
was not working though because relevant code would only get executed for
object hierarchies it seems), so now this is done for bones as well.

Fixes T88413.

Diff Detail

Repository
rB Blender
Branch
T88413 (branched from master)
Build Status
Buildable 14785
Build 14785: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.May 26 2021, 5:05 PM
Harbormaster completed remote builds in B14785: Diff 37524.May 26 2021, 5:05 PM
Philipp Oeser (lichtwerk) requested review of this revision.May 26 2021, 5:05 PM
Philipp Oeser (lichtwerk) added a project: User Interface.May 26 2021, 5:05 PM
Julian Eisel (Severin) accepted this revision.Jun 29 2021, 8:19 PM
This revision is now accepted and ready to land.Jun 29 2021, 8:19 PM
Bastien Montagne (mont29) accepted this revision.Jul 6 2021, 2:20 PM

LGTM :)

Philipp Oeser (lichtwerk) added a comment.Jul 6 2021, 2:51 PM

current (no indication of selection, no count)


with patch (with indication of selection, with count)

Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)Jul 8 2021, 10:22 AM
Sybren A. Stüvel (sybren) accepted this revision.Jul 8 2021, 10:24 AM

👍

Closed by commit rBb6a35a8153c3: Outliner: use 'compacted' row for bones as well (authored by Philipp Oeser (lichtwerk)). · Explain WhyJul 8 2021, 10:50 AM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rBb6a35a8153c3: Outliner: use 'compacted' row for bones as well.
Hadrien Brissaud (hadrien) awarded a token.Jul 13 2021, 10:06 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_outliner/
3 lines

Diff 37524

View Options

source/blender/editors/space_outliner/outliner_draw.c

Loading...