Differential D11427

Fix T88601: Attribute Compare Boolean doesn't expose socket
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on May 28 2021, 5:26 PM.

Tags

None

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T88601: Attribute Compare Boolean doesn't expose the expected value
Commits: rB20e250dae307: Fix T88601: Attribute Compare boolean doesn't expose socket

Summary

While we could make this node work for boolean inputs in the future,
currently it's really just designed to compare "float-like" inputs.
Many comparison modes don't even make sense for boolean inputs.
Therefore, the simplest fix for this bug is just to disable the
boolean attribute input modes for this node.

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.May 28 2021, 5:26 PM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B14834: Diff 37613.May 28 2021, 5:26 PM

Diff from 2.93 branch

Harbormaster completed remote builds in B14835: Diff 37614.May 28 2021, 5:28 PM

Charlie Jolly (charlie) mentioned this in T88601: Attribute Compare Boolean doesn't expose the expected value.May 28 2021, 5:32 PM

Hans Goudey (HooglyBoogly) added a task: T88601: Attribute Compare Boolean doesn't expose the expected value.May 28 2021, 5:36 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 28 2021, 6:05 PM

Closed by commit rB20e250dae307: Fix T88601: Attribute Compare boolean doesn't expose socket (authored by Hans Goudey (HooglyBoogly)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB20e250dae307: Fix T88601: Attribute Compare boolean doesn't expose socket.

Revision Contents
Changeset List

Path

Size

source/

blender/

makesrna/

intern/

4 lines

Diff 37615

source/blender/makesrna/intern/rna_nodetree.c

Loading...