EEVEE: Fix NaN caused by ensure_valid_reflection()
ClosedPublic
Actions

Authored by Clément Foucault (fclem) on May 28 2021, 6:10 PM.

Details

Reviewers

Dalai Felinto (dfelinto)
Brecht Van Lommel (brecht)

Maniphest Tasks

T86578: white artifacts in EEVEE

Commits

rBc36938297753: EEVEE: Fix NaN caused by ensure_valid_reflection()

Summary

This was caused by unsafe sqrt calls.

Fixes T86578 white artifacts in EEVEE

Diff Detail

Repository: rB Blender

Event Timeline

Clément Foucault (fclem) requested review of this revision.May 28 2021, 6:10 PM

Clément Foucault (fclem) created this revision.

Harbormaster completed remote builds in B14836: Diff 37616.May 28 2021, 6:10 PM

Clément Foucault (fclem) retitled this revision from Fix incorrect Denoise node SSE 4.1 warning on macOS Intel to EEVEE: Fix NaN caused by ensure_valid_reflection().May 28 2021, 6:13 PM

Clément Foucault (fclem) edited the summary of this revision. (Show Details)

Seems like this accidentally includes my last commit. But changing to safe sqrt should be pretty safe :)

This revision is now accepted and ready to land.May 28 2021, 6:13 PM

It works in my computer:

Operating system: Linux-5.8.0-50-generic-x86_64-with-glibc2.31 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 450.119.03

Closed by commit rBc36938297753: EEVEE: Fix NaN caused by ensure_valid_reflection() (authored by Clément Foucault (fclem)). · Explain WhyMay 28 2021, 6:18 PM

This revision was automatically updated to reflect the committed changes.

Clément Foucault (fclem) added a commit: rBc36938297753: EEVEE: Fix NaN caused by ensure_valid_reflection().

Andres Stephens (Draise) awarded a token.May 29 2021, 9:10 PM