Fix T88651: svg rect not using id as name
ClosedPublic
Actions

Authored by Falk David (filedescriptor) on May 29 2021, 11:54 AM.

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T88651: SVG not importing id attribute for rectangle - code resolution given in ticket

Commits

rBAf21f6d34bae2: Fix T88651: svg rect not using id as name

Summary

The rectangle shape was not using the id as the object name when
importing. All other shapes are doing it this way already.

The patch calls id_names_from_node to set the name to the id.
Credits go to @Arie Lakeman (ariejdl).

Diff Detail

Repository

rBA Blender Add-ons

Branch

master

Build Status

Buildable 14841
Build 14841: arc lint + arc unit

Event Timeline

Falk David (filedescriptor) requested review of this revision.May 29 2021, 11:54 AM

Falk David (filedescriptor) created this revision.

Harbormaster completed remote builds in B14841: Diff 37626.May 29 2021, 11:54 AM

Falk David (filedescriptor) added a task: T88651: SVG not importing id attribute for rectangle - code resolution given in ticket.May 29 2021, 11:56 AM

Falk David (filedescriptor) added a reviewer: Sergey Sharybin (sergey).

Falk David (filedescriptor) added a project: Add-ons (BF-Blender).

Falk David (filedescriptor) edited the summary of this revision. (Show Details)

Falk David (filedescriptor) added a subscriber: Arie Lakeman (ariejdl).

This revision is now accepted and ready to land.May 31 2021, 9:56 AM

Closed by commit rBAf21f6d34bae2: Fix T88651: svg rect not using id as name (authored by Falk David (filedescriptor)). · Explain WhyJun 1 2021, 9:21 AM

This revision was automatically updated to reflect the committed changes.

Falk David (filedescriptor) added a commit: rBAf21f6d34bae2: Fix T88651: svg rect not using id as name.

Revision Contents
Changeset List

Path

Size

io_curve_svg/

import_svg.py

2 lines

Diff 37626

View Options

io_curve_svg/import_svg.py

Fix T88651: svg rect not using id as nameClosedPublicActions