Differential D11434

Cleanup: Use arrayWithObject to reduce the code
ClosedPublic
Actions

Authored by Yuki Hashimoto (hzuika) on May 30 2021, 9:14 PM.

Tags

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rBc1ba68dd042c: Cleanup: use arrayWithObject to reduce the code

Summary

I replaced a temporary variable and verbose codes to arrayWithObject method.

This is a popular expression as it is also found in Apple's code samples.
https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/EventOverview/HandlingKeyEvents/HandlingKeyEvents.html

Diff Detail

Repository: rB Blender

Event Timeline

Yuki Hashimoto (hzuika) requested review of this revision.May 30 2021, 9:14 PM

Yuki Hashimoto (hzuika) created this revision.

Harbormaster completed remote builds in B14847: Diff 37636.May 30 2021, 9:14 PM

Yuki Hashimoto (hzuika) edited the summary of this revision. (Show Details)May 30 2021, 9:16 PM

Yuki Hashimoto (hzuika) edited the summary of this revision. (Show Details)May 30 2021, 9:24 PM

Yuki Hashimoto (hzuika) added a reviewer: Brecht Van Lommel (brecht).

Yuki Hashimoto (hzuika) added a project: Platform: macOS.

Yuki Hashimoto (hzuika) mentioned this in D11695: macOS: support Japanese input for text buttons.Jun 24 2021, 10:33 PM

Brecht Van Lommel (brecht) accepted this revision.Jul 5 2021, 12:57 PM

This revision is now accepted and ready to land.Jul 5 2021, 12:57 PM

Closed by commit rBc1ba68dd042c: Cleanup: use arrayWithObject to reduce the code (authored by Yuki Hashimoto (hzuika), committed by Brecht Van Lommel (brecht)). · Explain WhyJul 5 2021, 1:12 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rBc1ba68dd042c: Cleanup: use arrayWithObject to reduce the code.

Revision Contents
Changeset List

Path

Size

intern/

ghost/

intern/

GHOST_WindowViewCocoa.h

7 lines

Diff 39129

intern/ghost/intern/GHOST_WindowViewCocoa.h

Loading...